Differential D5931

hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'.
ClosedPublic
Actions

Authored by vlorentz on Jun 25 2021, 5:24 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3394: cassandra - origin url hashing encoding issue

Commits

rDMODcfb3073c27e0: hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'.

Summary

We agreed a while ago they should be IRIs and not just URIs.

This will trigger crashes in swh.storage.cassandra, as
currently expects (wrongly) that origin urls are ASCII.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 25 2021, 5:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 25 2021, 5:24 PM

vlorentz added a task: T3394: cassandra - origin url hashing encoding issue.Jun 25 2021, 5:25 PM

Build is green

Patch application report for D5931 (id=21294)

Rebasing onto 4009b3a3cf...

Current branch diff-target is up to date.

Changes applied before test

commit cfb3073c27e00d9cf9302897afce7c2555afc5fd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 17:24:40 2021 +0200

    hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'.
    
    We agreed a while ago they should be IRIs and not just URIs.
    
    This will trigger crashes in swh.storage.cassandra, as
    currently expects (wrongly) that origin urls are ASCII.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/361/ for more details.

Harbormaster completed remote builds in B22274: Diff 21294.Jun 25 2021, 5:26 PM

vlorentz requested review of this revision.Jun 25 2021, 5:26 PM

vlorentz mentioned this in D5932: cassandra: Add support for non-ASCII origin 'URLs'..Jun 25 2021, 5:27 PM

anlambert accepted this revision.Jun 28 2021, 1:56 PM

This revision is now accepted and ready to land.Jun 28 2021, 1:56 PM

Closed by commit rDMODcfb3073c27e0: hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'. (authored by vlorentz). · Explain WhyJun 28 2021, 3:38 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMODcfb3073c27e0: hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'..