tests/journal_client: Use pytest-redis fixture instead of mocks
ClosedPublic
Actions

Authored by anlambert on Jun 22 2021, 3:24 PM.

Details

Reviewers

ardumont
vsellier

Group Reviewers

Reviewers

Commits

rDCNTa3ea67faa9b9: tests/journal_client: Use pytest-redis fixture instead of mocks

Summary

It makes the tests much simpler to read, use of mocks should be avoided
when it is possible.

Diff Detail

Repository

rDCNT Archive counters

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 22 2021, 3:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 22 2021, 3:24 PM

Build is green

Patch application report for D5909 (id=21203)

Rebasing onto f4a98c8095...

Current branch diff-target is up to date.

Changes applied before test

commit e9fd9ff7900df7388c7c9c96997cdb8c021a560b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 22 15:23:17 2021 +0200

    tests/journal_client: Use pytest-redis fixture instead of mocks
    
    It makes the tests much simpler to read, use of mocks should be avoided
    when it is possible.

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/54/ for more details.

Harbormaster completed remote builds in B22189: Diff 21203.Jun 22 2021, 3:26 PM

anlambert requested review of this revision.Jun 22 2021, 3:26 PM

anlambert added a child revision: D5910: journal_client: Add origins processing.Jun 22 2021, 4:50 PM

ardumont accepted this revision.Jun 22 2021, 5:00 PM

This revision is now accepted and ready to land.Jun 22 2021, 5:00 PM

Rebase

Build is green

Patch application report for D5909 (id=21206)

Rebasing onto d4ce0c497f...

Current branch diff-target is up to date.

Changes applied before test

commit 2be3cf1bc226ac2b5e9051b0786926b2e0e48fa7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 22 15:23:17 2021 +0200

    tests/journal_client: Use pytest-redis fixture instead of mocks
    
    It makes the tests much simpler to read, use of mocks should be avoided
    when it is possible.

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/56/ for more details.

Harbormaster completed remote builds in B22193: Diff 21206.Jun 22 2021, 5:06 PM

LGTM thanks it's obviously less complicated

Just a little observation regarding an unused constant

swh/counters/tests/test_journal_client.py
26–27	this constant is not used anymore if I'm not wrong

anlambert added inline comments.Jun 22 2021, 5:22 PM

swh/counters/tests/test_journal_client.py
26–27	Right, I forgot to remove it. Let's do the rebase dance again then ;-)

Remove no longer used constant

Build is green

Patch application report for D5909 (id=21209)

Rebasing onto d4ce0c497f...

Current branch diff-target is up to date.

Changes applied before test

commit a3ea67faa9b995990d58fbba45e5342002304294
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 22 15:23:17 2021 +0200

    tests/journal_client: Use pytest-redis fixture instead of mocks
    
    It makes the tests much simpler to read, use of mocks should be avoided
    when it is possible.

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/58/ for more details.

Harbormaster completed remote builds in B22196: Diff 21209.Jun 22 2021, 5:26 PM

Closed by commit rDCNTa3ea67faa9b9: tests/journal_client: Use pytest-redis fixture instead of mocks (authored by anlambert). · Explain WhyJun 22 2021, 5:35 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCNTa3ea67faa9b9: tests/journal_client: Use pytest-redis fixture instead of mocks.