Differential D5908

journal_client: Use CountersInterface for counters typing
ClosedPublic
Actions

Authored by anlambert on Jun 22 2021, 3:06 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCNTd4ce0c497f87: journal_client: Use CountersInterface for counters typing

Summary

Journal client can also be used with the in memory counters so use
counters interface for typing instead of redis implementation.

Diff Detail

Repository

rDCNT Archive counters

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 22 2021, 3:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 22 2021, 3:06 PM

Build is green

Patch application report for D5908 (id=21202)

Rebasing onto f4a98c8095...

Current branch diff-target is up to date.

Changes applied before test

commit d4ce0c497f87a319be7a75a333cc50367b8eeb92
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 22 15:05:54 2021 +0200

    journal_client: Use CountersInterface for counters typing
    
    Journal client can also be used with the in memory counters so use
    counters interface for typing instead of redis implementation.

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B22188: Diff 21202.Jun 22 2021, 3:08 PM

anlambert requested review of this revision.Jun 22 2021, 3:08 PM

ardumont accepted this revision.Jun 22 2021, 4:59 PM

This revision is now accepted and ready to land.Jun 22 2021, 4:59 PM

Closed by commit rDCNTd4ce0c497f87: journal_client: Use CountersInterface for counters typing (authored by anlambert). · Explain WhyJun 22 2021, 5:00 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCNTd4ce0c497f87: journal_client: Use CountersInterface for counters typing.