Differential D5915

elasticsearch.py: Improve readability of painless script
ClosedPublic
Actions

Authored by KShivendu on Jun 23 2021, 4:57 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSEA3e153035287b: elasticsearch.py: Improve readability of painless script

Summary

Number of fields in ES is expected to grow with time
so the update script should be easy to read.

Suggested by @anlambert in D5883#151171

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

KShivendu created this revision.Jun 23 2021, 4:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 23 2021, 4:57 PM

Build is green

Patch application report for D5915 (id=21237)

Rebasing onto 9bedaa95a3...

Current branch diff-target is up to date.

Changes applied before test

commit 87abf7c6b9113698d3edf3cdd86690c12d41d77b
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Jun 23 14:48:04 2021 +0000

    elasticsearch.py: Improve readability of painless script

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/164/ for more details.

Harbormaster completed remote builds in B22221: Diff 21237.Jun 23 2021, 5:02 PM

KShivendu requested review of this revision.Jun 23 2021, 5:02 PM

KShivendu edited the summary of this revision. (Show Details)Jun 23 2021, 5:02 PM

KShivendu added a subscriber: anlambert.

Improve commit body

KShivendu edited the summary of this revision. (Show Details)Jun 23 2021, 5:15 PM

Build is green

Patch application report for D5915 (id=21241)

Rebasing onto 9bedaa95a3...

Current branch diff-target is up to date.

Changes applied before test

commit 3e153035287bd41c998921e59a453e42cba61aa6
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Wed Jun 23 14:48:04 2021 +0000

    elasticsearch.py: Improve readability of painless script
    
    Number of fields in ES is expected to grow with time
    so the update script should be easy to read.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/165/ for more details.

Harbormaster completed remote builds in B22225: Diff 21241.Jun 23 2021, 5:17 PM

Great, thanks !

This revision is now accepted and ready to land.Jun 23 2021, 5:21 PM

Closed by commit rDSEA3e153035287b: elasticsearch.py: Improve readability of painless script (authored by KShivendu). · Explain WhyJun 23 2021, 6:01 PM

This revision was automatically updated to reflect the committed changes.

KShivendu added a commit: rDSEA3e153035287b: elasticsearch.py: Improve readability of painless script.