rebase
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 24 2020
Jun 23 2020
rebase
remove the previously added revision and fix the actual bug instead
rebase
add a revision to fix test_origin_visit_status_add_twice
Not sure about implications of the branches_count=1 argument, but it may be related to my other comment. Otherwise, LGTM.
Much easier to review! Thanks.
Jun 22 2020
rebase
reword the commit message and fix cassandra impl
rebase
Fix for cassandra
Looks good to me but I would have preferred to see the "use assert_last_visit_matches" chuncks, which are a "pure" refactoring step, in a dedicated commit (so split this commit in 2 parts).
typo in commit msg
Jun 17 2020
prevent some timeout-kind-of stuff in test_backfiller
fix a couple of tests in test_backfill
In D3299#80579, @ardumont wrote:\m/
Thanks!
The description does not say it but you also dealt with origin-visit-status so another thanks!
Jun 16 2020
update the docstring and add type annotations
typo in a ci msg
Jun 15 2020
not completely sure why this is necessary, but meh
add a warning in the commit message
Jun 12 2020
As discussed on IRC, a possible fix for is to clearly document the "limitations" of the current implementation.
In D3263#79681, @vlorentz wrote:This is needed to help consuming existing (invalid) messages from kafka.
If this is the only purpose, it should be in swh.storage.fixer
In D3263#79805, @olasd wrote:As I've pointed out on IRC, I think (offset, negative_utc) == (0, None) should raise an error, as this is undefined behavior.
Jun 11 2020
besides I don't like the _scheduler global var name, LGTM
Jun 10 2020
lgtm but see my comments, in case you agree with them.
Jun 8 2020
Jun 5 2020
fix the failing test
typo