make it consistent with other add_xxx methods, ie. make it return a
summary dict.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDSTOfb603e1b9874: Make Storage.add_origin() return a sumary dict
Tests of all dependencies (but swh-web, see D3326) should pass OK.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3327 (id=11786)
Rebasing onto 041543df09...
First, rewinding head to replay your work on top of it... Applying: Refactor the Storage.add_origin API
Changes applied before test
commit 5bb22b8d6b629cba0a86d574d7e9748e17b5232c
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Jun 18 18:28:51 2020 +0200
Refactor the Storage.add_origin API
make it consistent with other add_xxx methods, ie. make it return a
summary dict.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/323/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/323/console
Comment Actions
Build has FAILED
Patch application report for D3327 (id=11796)
Rebasing onto 041543df09...
First, rewinding head to replay your work on top of it... Applying: Refactor the Storage.add_origin API
Changes applied before test
commit 4a8e2cf9d048e6939ca8fa37f1a632c7b876b2c2
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Jun 18 18:28:51 2020 +0200
Refactor the Storage.add_origin API
make it consistent with other add_xxx methods, ie. make it return a
summary dict.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/326/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/326/console
Comment Actions
Build has FAILED
Patch application report for D3327 (id=11796)
Rebasing onto 041543df09...
First, rewinding head to replay your work on top of it... Applying: Refactor the Storage.add_origin API
Changes applied before test
commit b666b60209ddac2a000d5e97362f3b3df932466f
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Jun 18 18:28:51 2020 +0200
Refactor the Storage.add_origin API
make it consistent with other add_xxx methods, ie. make it return a
summary dict.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/329/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/329/console
Comment Actions
Could you change the first line of your commit message to explain what it changed?
| swh/storage/cassandra/storage.py | ||
|---|---|---|
| 765 | It is, but it doesn't matter. If an origin gets inserted twice at the same time, both entries have the same primary key, so only the latter is kept. | |
| 766–770 | Remove the brackets around the call to origin_get | |
| swh/storage/cassandra/storage.py | ||
|---|---|---|
| 765 | Now I remember: what may be inconsistent is the number of origin added retruned in the status dict {"origin:add": n} but I guess it's not really a problem. | |
| swh/storage/cassandra/storage.py | ||
|---|---|---|
| 765 | yup. all stats are approximates anyway | |
Comment Actions
Build has FAILED
Patch application report for D3327 (id=11813)
Rebasing onto 2d497ff07c...
First, rewinding head to replay your work on top of it... Applying: Make Storage.add_origin() return a sumary dict
Changes applied before test
commit 935e5c71b1bdc72805ea69ca569a7bca5af800f6
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Jun 18 18:28:51 2020 +0200
Make Storage.add_origin() return a sumary dict
make it consistent with other add_xxx methods by making it return a
summary dict `{"origin:add": int}`.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/331/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/331/console
| swh/storage/cassandra/storage.py | ||
|---|---|---|
| 766–770 | To repeat what i've said on irc, I think that filtering might be probably the root cause of the current tests failing... | |
Comment Actions
add a revision to fix test_origin_visit_status_add_twice
needed for the tests to pass ok with the cassandra backend after
the refactoring.
Comment Actions
Build has FAILED
Patch application report for D3327 (id=11836)
Rebasing onto 2d497ff07c...
First, rewinding head to replay your work on top of it... Applying: Simplify/fix test_origin_visit_status_add_twice Applying: Make Storage.add_origin() return a sumary dict
Changes applied before test
commit 22b602541c9919557cc9c122d8e24912d0be2d56
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Jun 18 18:28:51 2020 +0200
Make Storage.add_origin() return a sumary dict
make it consistent with other add_xxx methods by making it return a
summary dict `{"origin:add": int}`.
commit d706e200687f569c05cceebc8645a8cfde22a9ab
Author: David Douard <david.douard@sdfa3.org>
Date: Mon Jun 22 17:47:26 2020 +0200
Simplify/fix test_origin_visit_status_add_twice
do not make assumptions on how the backend storage will manage idempotence
related to the journal.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/335/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/335/console
Comment Actions
Build is green
Patch application report for D3327 (id=11840)
Rebasing onto 2d497ff07c...
Current branch diff-target is up to date.
Changes applied before test
commit fb603e1b9874a3bbb393f7653ec5004bfa18b251
Author: David Douard <david.douard@sdfa3.org>
Date: Thu Jun 18 18:28:51 2020 +0200
Make Storage.add_origin() return a sumary dict
make it consistent with other add_xxx methods by making it return a
summary dict `{"origin:add": int}`.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/337/ for more details.