Differential D3294

model.hypothesis_strategies: Make metadata always none on origin_visit
ClosedPublic
Actions

Authored by ardumont on Jun 16 2020, 7:16 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDMODba0c4e19e6b0: model.hypothesis_strategies: Make metadata always none on origin_visit

Summary

This is not currently not used in production.

This is broken storage side [1]

And finally, this is temporary as this will soon go away with T2310 [2]

[1] origin-visit-add does not deal correctly with metadata
(origin-visit-status-add does it well though). And it so happens there is no
test around it... So unfortunately it only got detected by @douardda's run with
the backfiller or something. It's good it got detected though ¯\_(ツ)_/¯

[2] we are currently phasing out multiple origin-visit fields including this
one

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 16 2020, 7:16 PM

Build is green

Patch application report for D3294 (id=11675)

Rebasing onto f723eb12af...

Current branch diff-target is up to date.

Changes applied before test

commit ba0c4e19e6b01f0c9585832f7fe430975f48ab8c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 16 19:10:53 2020 +0200

    model.hypothesis_strategies: Make metadata always none on origin_visit
    
    This is not used. This is broken storage wise (origin-visit-add does not deal
    correctly with it and it so happens there is no test around it).
    
    And finally, this will soon go away with T2310.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/74/ for more details.

Harbormaster completed remote builds in B12883: Diff 11675.Jun 16 2020, 7:17 PM

ardumont edited the summary of this revision. (Show Details)Jun 16 2020, 7:18 PM

ardumont edited the summary of this revision. (Show Details)Jun 16 2020, 7:25 PM

ardumont edited the summary of this revision. (Show Details)Jun 16 2020, 8:23 PM

ardumont mentioned this in D3297: Set origin visits' metadata to None in journal_data.Jun 17 2020, 9:24 AM

douardda accepted this revision.Jun 17 2020, 9:30 AM

This revision is now accepted and ready to land.Jun 17 2020, 9:30 AM

Closed by commit rDMODba0c4e19e6b0: model.hypothesis_strategies: Make metadata always none on origin_visit (authored by ardumont). · Explain WhyJun 17 2020, 9:37 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMODba0c4e19e6b0: model.hypothesis_strategies: Make metadata always none on origin_visit.

Revision Contents
Changeset List

Path

Size

swh/

model/

hypothesis_strategies.py

1 line

Diff 11686

View Options

swh/model/hypothesis_strategies.py

model.hypothesis_strategies: Make metadata always none on origin_visitClosedPublicActions