Page MenuHomeSoftware Heritage

Fix/update the backfiller
ClosedPublic

Authored by douardda on Wed, Jun 17, 9:41 AM.

Details

Summary

The backfiller has not been updated to match recent changes in several
places. This has not been detected because there was no proper test
of the backfiller function as a whole. This is now done.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Wed, Jun 17, 9:41 AM
ardumont added a subscriber: ardumont.EditedWed, Jun 17, 9:47 AM

\m/

Thanks!

The description does not say it explicitely but you also dealt with origin-visit-status so another thanks!

Cheers,

\m/

Thanks!

The description does not say it but you also dealt with origin-visit-status so another thanks!

Well, this updates the backfiller, so that includes adding support for origin-visit-status objects indeed.

Build has FAILED

Patch application report for D3299 (id=11687)

Rebasing onto d153a8096d...

First, rewinding head to replay your work on top of it...
Applying: Fix/update the backfiller
Changes applied before test
commit 3d167c6fa047db408cc78b5d2021ec9170035050
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 17 09:23:11 2020 +0200

    Fix/update the backfiller
    
    The backfiller has not been updated to match recent changes in several
    places. This has not been detected because there was no proper test
    of the backfiller function as a whole. This is now done.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/289/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/289/console

ardumont accepted this revision.Wed, Jun 17, 10:09 AM

forgot to validate it !

This revision is now accepted and ready to land.Wed, Jun 17, 10:09 AM
douardda updated this revision to Diff 11689.Wed, Jun 17, 10:19 AM

fix a couple of tests in test_backfill

Build is green

Patch application report for D3299 (id=11689)

Rebasing onto d153a8096d...

First, rewinding head to replay your work on top of it...
Applying: Fix/update the backfiller
Changes applied before test
commit a0533d7ae105b33779fbac38cc47dca1290380d8
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 17 09:23:11 2020 +0200

    Fix/update the backfiller
    
    The backfiller has not been updated to match recent changes in several
    places. This has not been detected because there was no proper test
    of the backfiller function as a whole. This is now done.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/291/ for more details.

douardda updated this revision to Diff 11692.Wed, Jun 17, 11:09 AM

prevent some timeout-kind-of stuff in test_backfiller

so the test execution time goes from 300+s to 30s (which remains a lot, but...)

Build is green

Patch application report for D3299 (id=11692)

Rebasing onto d153a8096d...

First, rewinding head to replay your work on top of it...
Applying: Fix/update the backfiller
Changes applied before test
commit 2d343df23f956b67bc1e704a8cc934a8a617852c
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 17 09:23:11 2020 +0200

    Fix/update the backfiller
    
    The backfiller has not been updated to match recent changes in several
    places. This has not been detected because there was no proper test
    of the backfiller function as a whole. This is now done.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/293/ for more details.

Build is green

Patch application report for D3299 (id=11694)

Rebasing onto d153a8096d...

Current branch diff-target is up to date.
Changes applied before test
commit 3e99c14e165b53ea9778283d49ae6bc1df3fe611
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 17 09:23:11 2020 +0200

    Fix/update the backfiller
    
    The backfiller has not been updated to match recent changes in several
    places. This has not been detected because there was no proper test
    of the backfiller function as a whole. This is now done.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/295/ for more details.

Build is green

Patch application report for D3299 (id=11698)

Rebasing onto 057c6fd5df...

Current branch diff-target is up to date.
Changes applied before test
commit 692bfa3944829fb4d0f6b8a66ef88fee43c877ff
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jun 17 09:23:11 2020 +0200

    Fix/update the backfiller
    
    The backfiller has not been updated to match recent changes in several
    places. This has not been detected because there was no proper test
    of the backfiller function as a whole. This is now done.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/297/ for more details.

This revision was automatically updated to reflect the committed changes.