Page MenuHomeSoftware Heritage

Do not use the returned value of storage.origin_add in tests
ClosedPublic

Authored by douardda on Mon, Jun 22, 10:56 AM.

Details

Summary

this API is about to change (will return a stats dict like other endpoints)
and it is actually not needed.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mon, Jun 22, 10:56 AM
ardumont accepted this revision.Mon, Jun 22, 10:59 AM
ardumont added a subscriber: ardumont.

Right.

This revision is now accepted and ready to land.Mon, Jun 22, 10:59 AM

Build is green

Patch application report for D3326 (id=11778)

Rebasing onto 9358473580...

Current branch diff-target is up to date.
Changes applied before test
commit d59f8080bc8a003ee1808038c5a6feb836af1569
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jun 22 10:50:35 2020 +0200

    Do not use the returned value of storage.origin_add in tests
    
    this API is about to change (will return a stats dict like other endpoints)
    and it is actually not needed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/209/ for more details.

Build is green

Patch application report for D3326 (id=11854)

Rebasing onto c18cd1a877...

Current branch diff-target is up to date.
Changes applied before test
commit e8f3588ede5f06bb3fb2d78785ae07ac1b1cc24d
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Jun 22 10:50:35 2020 +0200

    Do not use the returned value of storage.origin_add in tests
    
    this API is about to change (will return a stats dict like other endpoints)
    and it is actually not needed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/216/ for more details.