Differential D3232

Add a replayer test for anonymized journal topics
ClosedPublic
Actions

Authored by douardda on Jun 5 2020, 12:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO88271f80dc68: Add a replayer test for anonymized journal topics

Summary

This new test check the behavior of the storage replayer mechanism when
replaying a journal with privileged topics.

Depends on D3231.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jun 5 2020, 12:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2020, 12:33 PM

Build is green

Patch application report for D3232 (id=11457)

Could not rebase; Attempt merge onto 25f584ffc4...

Updating 25f584f..486b78b
Fast-forward
 swh/storage/in_memory.py               |  24 +++----
 swh/storage/tests/test_kafka_writer.py | 110 ++++++++++++++++++++++++++++++---
 swh/storage/tests/test_replay.py       | 103 +++++++++++++++++++++++++++++-
 3 files changed, 213 insertions(+), 24 deletions(-)

Changes applied before test

commit 486b78b89e4149588d679655cb4a89ab01db0cc4
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu May 7 15:33:35 2020 +0200

    Add a replayer test for anonymized journal topics
    
    This new test check the behavior of the storage replayer mechanism when
    replaying a journal with privileged topics.

commit c75da7a90e1d9c1418600b1b9519afc2ab447d6e
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jun 5 12:25:58 2020 +0200

    Small refactoring of the InMemoryStorage to make it more consistent
    
    - make self._persons a dict
    - make self._snapshots value Snapshot only instead of the couple
      (Snapshot, sorted_branch_names)

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/229/ for more details.

Harbormaster completed remote builds in B12661: Diff 11457.Jun 5 2020, 12:48 PM

ardumont accepted this revision.Jun 5 2020, 6:04 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/storage/tests/test_replay.py
278	replay`s`

This revision is now accepted and ready to land.Jun 5 2020, 6:04 PM

douardda marked an inline comment as done.Jun 5 2020, 6:12 PM

typo

Build is green

Patch application report for D3232 (id=11476)

Rebasing onto c75da7a90e...

Current branch diff-target is up to date.

Changes applied before test

commit 88271f80dc6843f00ccf09d3860964621e9ae88d
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu May 7 15:33:35 2020 +0200

    Add a replayer test for anonymized journal topics
    
    This new test check the behavior of the storage replayer mechanism when
    replaying a journal with privileged topics.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/236/ for more details.

Harbormaster completed remote builds in B12681: Diff 11476.Jun 5 2020, 6:22 PM

Closed by commit rDSTO88271f80dc68: Add a replayer test for anonymized journal topics (authored by douardda). · Explain WhyJun 5 2020, 6:27 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTO88271f80dc68: Add a replayer test for anonymized journal topics.