Page MenuHomeSoftware Heritage

Fix db_to_author() converter to return None is all fields are None
ClosedPublic

Authored by douardda on Tue, Jun 16, 12:22 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Jun 16, 12:22 PM
olasd added a subscriber: olasd.Tue, Jun 16, 12:26 PM

Looks like a plausible change.

Please fix the docstring, which is obviously lying :-)

Build is green

Patch application report for D3290 (id=11664)

Rebasing onto 8f1ac4cb13...

Current branch diff-target is up to date.
Changes applied before test
commit 990ac281fd4108fd0ef8a90e76e774820c854d15
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 12:19:13 2020 +0200

    Fix db_to_author() converter to return None is all fields are None
    
    Fix T2455.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/283/ for more details.

douardda updated this revision to Diff 11665.Tue, Jun 16, 12:35 PM

update the docstring and add type annotations

olasd accepted this revision.Tue, Jun 16, 12:35 PM
This revision is now accepted and ready to land.Tue, Jun 16, 12:35 PM

Build is green

Patch application report for D3290 (id=11665)

Rebasing onto 8f1ac4cb13...

Current branch diff-target is up to date.
Changes applied before test
commit c2b673b49b88395a5b4d21d2e0b39462e50cc459
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 12:19:13 2020 +0200

    Fix db_to_author() converter to return None is all fields are None
    
    Fix T2455.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/284/ for more details.