Fix the model: Revision.message can be None
ClosedPublic
Actions

Authored by douardda on Jun 16 2020, 10:09 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDMODf723eb12af67: Fix the model: Revision.message can be None
rDMODb70b281404ff: Fix message generation in hypothesis strategy releases_d()
rDMOD5c5f34fe7233: Use the optional() strategy instead of one_of(none(), ...) when possible

Summary

And adapt the revisions_d() strategy accordingly.

Also:

Use the optional() strategy instead of ome_of(none(), ...) when possible for the sake of consistency.

Fix message generation in hypothesis strategy releases_d() This can be None, according to the model.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jun 16 2020, 10:09 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 16 2020, 10:09 AM

Build is green

Patch application report for D3285 (id=11654)

Rebasing onto a427e184fb...

Current branch diff-target is up to date.

Changes applied before test

commit 18b1062e19616c1e23556ec202ff781910ddaf46
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 10:04:58 2020 +0200

    Fix the model: Revision.message can be None
    
    And adapt the revisions_d() strategy accordingly.

commit 2c9ec4a0724624d85f8a9289f5bb725421a29b38
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 10:03:37 2020 +0200

    Fix message generation in hypothesis strategy releases_d()
    
    This can be None, according to the model.

commit b30aa43f80c053f291a318dcae2527edd92ab6b9
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 10:02:17 2020 +0200

    Use the optional() strategy instead of ome_of(none(), ...) when possible
    
    for the sake of consistency.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/72/ for more details.

Harbormaster completed remote builds in B12862: Diff 11654.Jun 16 2020, 10:11 AM

You've got a typo in one of the messages (ome_of instead of one_of), but that all looks good, thanks!

This revision is now accepted and ready to land.Jun 16 2020, 10:27 AM

typo in a ci msg

This revision was landed with ongoing or failed builds.Jun 16 2020, 10:38 AM

Closed by commit rDMOD5c5f34fe7233: Use the optional() strategy instead of one_of(none(), ...) when possible (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMOD5c5f34fe7233: Use the optional() strategy instead of one_of(none(), ...) when possible.

douardda added a commit: rDMODb70b281404ff: Fix message generation in hypothesis strategy releases_d().

douardda added a commit: rDMODf723eb12af67: Fix the model: Revision.message can be None.

Build is green

Patch application report for D3285 (id=11655)

Rebasing onto a427e184fb...

Current branch diff-target is up to date.

Changes applied before test

commit f723eb12af67f3a2f5613ac6650ff2480282e0ef
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 10:04:58 2020 +0200

    Fix the model: Revision.message can be None
    
    And adapt the revisions_d() strategy accordingly.

commit b70b281404fff1ad5d15f6a551f52356e98c6025
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 10:03:37 2020 +0200

    Fix message generation in hypothesis strategy releases_d()
    
    This can be None, according to the model.

commit 5c5f34fe7233026929a6c9842157af07adf6c8a3
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 10:02:17 2020 +0200

    Use the optional() strategy instead of one_of(none(), ...) when possible
    
    for the sake of consistency.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/73/ for more details.

Harbormaster completed remote builds in B12863: Diff 11655.Jun 16 2020, 10:39 AM