In D2123#49304, @vlorentz wrote:

I also prefer the new line-breaking style, there's less space wasted by indentations

I've marked this as depending on D2120, as the encoding fix for the CRAN lister (formerly known as D2125) has been integrated there.

In D2125#49275, @ardumont wrote:

This is now obsolete as that was merged within the D2120 diff which add integration test and fixes the cran lister behavior.

• typing: minimal changes to make a no-op mypy run pass
• mypy: use sqlalchemy plugin

• mypy: use sqlalchemy plugin

In D2088#48849, @ardumont wrote:

Needs a rebase (as i modified slightly the tox.ini today).

Looks good, but I'm puzzled by some testing results.

In a subsequent commit please update also docs/api.rst to document the new methods (a catch-all thing to document all of them at once would do too).

btw, I've tested this diff manually in tox and it does build fine

thanks a lot @DanSeraf!, this has now been accepted, landed to master, and you've been added to the CONTRIBUTORS file :-)

oh, and remember to add a "Closes: T1986" line to the diff description (and commit), so that there is a link with the corresponding issue

In D2070#47879, @anlambert wrote:

To install mypy in the docker image used to run the tests, you have to modify that Dockerfile.
You will have to land the dockerfile change prior to that diff of course.

In D2032#47733, @douardda wrote:

where should the mypy_django_plugin dependency be? looks like this is required.

Hheya, thanks a lot for this contribution !

nice catch!

not sure where I saw that kwd argument…

In D2056#47634, @olasd wrote:

Would it be possible to make that extra dependency on dulwich optional, e.g. only installed when requesting swh.model[identify]?

• setup.py: move CLI dependencies to a dedicated swh-model[cli] subpackage
• mypi.ini: remove left-over "false positive" comment from dulwich exclude

• tox: anticipate mypy run to just after flake8

• tox: add mypy environment