Page MenuHomeSoftware Heritage
Differential D2088

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Authored by zack on Oct 8 2019, 3:53 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDTARda20d00b68b5: typing: minimal changes to make a no-op mypy run pass
Test Plan

tox -e mypy

Diff Detail

Repository
rDLDTAR Tarball Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Oct 8 2019, 3:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 8 2019, 3:53 PM
zack added a parent revision: D2087: typing: minimal changes to make a no-op mypy run pass.Oct 8 2019, 3:54 PM
swh-public-ci added a comment.Oct 8 2019, 3:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/109/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/109/console

Harbormaster failed remote builds in B8178: Diff 7008!Oct 8 2019, 3:55 PM
swh-public-ci added a comment.Oct 8 2019, 5:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/110/ for more details.

Harbormaster completed remote builds in B8178: Diff 7008.Oct 8 2019, 5:12 PM
ardumont accepted this revision.Oct 9 2019, 11:22 PM
ardumont added a subscriber: ardumont.

Needs a rebase (as i modified slightly the tox.ini today).

This revision is now accepted and ready to land.Oct 9 2019, 11:22 PM
Closed by commit rDLDTARda20d00b68b5: typing: minimal changes to make a no-op mypy run pass (authored by zack). · Explain WhyOct 10 2019, 10:11 AM
This revision was automatically updated to reflect the committed changes.
zack added a commit: rDLDTARda20d00b68b5: typing: minimal changes to make a no-op mypy run pass.
zack added a comment.Oct 10 2019, 10:11 AM
In D2088#48849, @ardumont wrote:

Needs a rebase (as i modified slightly the tox.ini today).

The changes were not conflicting. I've just merged.

Revision Contents
Changeset List

PathSize
1 line
1 line
21 lines
swh/
5 lines
loader/
5 lines
tar/
2 lines
1 line
tests/
2 lines
10 lines

Diff 7067

View Options

.gitignore

Loading...
View Options

MANIFEST.in

Loading...
View Options

mypy.ini

Loading...
View Options

swh/__init__.py

Loading...
View Options

swh/loader/__init__.py

Loading...
View Options

swh/loader/tar/loader.py

Loading...
View Options

swh/loader/tar/py.typed

Loading...
View Options

swh/loader/tar/tests/conftest.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal