pytest .
Details
Details
- Reviewers
zack - Group Reviewers
Reviewers - Commits
- rDGRPHe56d20dab88c: graph.py: add 'deep' methods
rDGRPH0faa2750f815: Add low level API (WIP)
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Branch
- lowlevel_api
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8154 Build 11751: tox-on-jenkins Jenkins Build 11750: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/61/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/61/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/62/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/63/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/64/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/65/ for more details.
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/66/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/66/console
| swh/graph/backend.py | ||
|---|---|---|
| 126 | why the explicit timeout here? | |
| swh/graph/graph.py | ||
| 12–19 | this looks graphviz-specific, so it should go in swh.graph.dot instead | |
| 45 | It's not clear to me why the first argument is called "parent_graph" (here, and everywhere in the module). Isn't it just the graph the various visitors are working on? | |
| swh/graph/backend.py | ||
|---|---|---|
| 126 | I'm gonna add a comment for the timeout. No, this is only for opening the FIFO, not reading it, so it can't fail like that. The FIFO is opened on both sides at the beginning. The problem is, if there is an exception in the java call thread and the FIFO is never created, this thread will block endlessly without timeout, because the FIFO has to be opened from both sides for the open(2) call to return. Adding a timeout for this open() call allows Java exceptions that happen between the Java call and the open() on the Java side to be propagated to the main thread. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/67/ for more details.