tests

rebase

changes

requested changes

• non-minified css in assets

• workaround to check the table body
• bootstrap css update

In D3293#81217, @vlorentz wrote:

In D3293#81209, @DanSeraf wrote:

Unfortunately the expected values can't be tested.

Why not?

Because the dash_html_components checks for object identity only. I wrote a comment inside the test.

In D3293#80514, @vlorentz wrote:

• It's missing tests. I understand it's not easy to do for a GUI, but could you see what you can do about it?

• init.py in dashboard directory

• css as static asset

• wrong check when using the source path

wrong directory check

rebase

missing import in mypy.ini

rebase

requested changes

update

update

rebase

parent

child diff

squash

child diff

In D3069#74580, @vlorentz wrote:

Could you split this into two diffs?

The new json output will be like the following:

requested changes

• requirements-swh: swh.model version >= 0.0.65
• match pattern with fnmatch
• tests adapted to accept exclude patterns

In D2989#72502, @ardumont wrote:

(maybe not immediately though, it's currently building ;).

it's built so it's fine now ;)

In D2989#72439, @vlorentz wrote:

Instead of building the set of all paths to exclude (possibly very large), I think you should pass patterns to directory_filter and use [[ https://docs.python.org/3/library/fnmatch.html | fnmatch ]] there

In D2960#71967, @ardumont wrote:

Looks good to me.

Don't you want to implement your callable here (the one which actually exclude stuff)?

Because now, the diff title is no longer in sync with the code ;)

Or do you plan to add it in swh-scanner?

requested changes

requested changes

In D2960#71669, @ardumont wrote:

I can define a dir_filter function but how could i get the values i need, like the full path generated inside from_disk, without touching the implementation?

I'm not sure i understand the question.
from_disk has a save_path parameter. If set to True, the paths are stored alongside the output result.
Isn't that enough?

In D2960#71656, @ardumont wrote:

I think in the end, this should be implemented with the dir_filter parameter instead.

Please, check that you can do this. If you can, this will, there is no need to change the current implementation.
And instead, either:

• not touch swh.model at all, then define your ignore_path function in swh-scanner and use it when calling from_disk.
• if you think, this can be a shared behavior (i guess it can), define a function callable here in swh-model (like accept_all_directories and the other ones next to it).

In both cases, this won't touch Directory.from_disk though.

rebase