Differential D2059

Dict's get method does not take keyword argument
ClosedPublic
Actions

Authored by ardumont on Oct 2 2019, 7:00 AM.

Details

Reviewers

zack
vlorentz

Group Reviewers

Reviewers

Commits

rDSCH5955c8d738b8: celery_backend/config: Fix wrong statement

Summary

Prior to this, i was unable to start the swh-lister within the docker-dev (with
fresh update on the container)

The failure is detailed below [1]

Note:
and mypy does not complain ;)

[1] Related D2033#47672

Test Plan

tox
doco up -d swh-lister (with local override) -> it starts now

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 2 2019, 7:00 AM

ardumont mentioned this in D2033: typing: minimal changes to make a no-op mypy run pass.Oct 2 2019, 7:01 AM

Harbormaster completed remote builds in B8068: Diff 6924.Oct 2 2019, 7:02 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/295/ for more details.

not sure where I saw that kwd argument…

thanks!

This revision is now accepted and ready to land.Oct 2 2019, 8:18 AM

Closed by commit rDSCH5955c8d738b8: celery_backend/config: Fix wrong statement (authored by ardumont). · Explain WhyOct 2 2019, 9:35 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH5955c8d738b8: celery_backend/config: Fix wrong statement.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

celery_backend/

config.py

2 lines

Diff 6928

View Options

swh/scheduler/celery_backend/config.py

Dict's get method does not take keyword argumentClosedPublicActions