Page MenuHomeSoftware Heritage
Feed Advanced Search

Jul 1 2019

douardda updated the diff for D1659: api/sync: allow to configure requests for pool size and retries.

do only mount the adapter on expected url

Jul 1 2019, 10:27 AM
douardda added a project to T1864: Inkscape is not mentioned as dependency for building swh-docs: Documentation.
Jul 1 2019, 10:08 AM · Documentation

Jun 29 2019

douardda committed rMSLD34de2ae55c03: status extended module: move the architecture diagram just after the swstack (authored by douardda).
status extended module: move the architecture diagram just after the swstack
Jun 29 2019, 11:47 PM

Jun 28 2019

Herald added a reviewer for D1659: api/sync: allow to configure requests for pool size and retries: Reviewers.
Jun 28 2019, 12:16 PM
douardda committed rCDFD9b12218d59cd: entrypoints: ensure gunicorn services can handle more than one connection (authored by douardda).
entrypoints: ensure gunicorn services can handle more than one connection
Jun 28 2019, 11:49 AM
douardda closed D1651: entrypoints: ensure guncorn services can handle more than one connection.
Jun 28 2019, 11:49 AM
douardda added a comment to D1651: entrypoints: ensure guncorn services can handle more than one connection.

Otherwise what's the point of using gunicorn...

To give more details.
As an example, if we list something and by luck we start loading a huge repository... then the storage cannot handle both adding new data in the model and allow another connection from other services, say for example the web app ;)

Jun 28 2019, 10:50 AM
douardda updated the diff for D1651: entrypoints: ensure guncorn services can handle more than one connection.

fixes according to vlorentz' comment

Jun 28 2019, 10:48 AM
douardda added a comment to T1828: Improve directory journal backfill performance.

1 month is good enough. Let's stick to this.

Jun 28 2019, 10:13 AM · Mirror, Journal

Jun 27 2019

douardda committed rMSLDeeb65ea45fbe: status-extended: fix mandatory trailing ws (!) (authored by douardda).
status-extended: fix mandatory trailing ws (!)
Jun 27 2019, 11:24 AM
douardda committed rMSLDf1be2ee4bbf0: Updates of 2019 PSES slides (authored by douardda).
Updates of 2019 PSES slides
Jun 27 2019, 11:10 AM
douardda committed rMSLD3f5ff4554d6c: Small rewording (authored by douardda).
Small rewording
Jun 27 2019, 11:10 AM
douardda committed rMSLD20b01fde1226: update the growth graph and add a few slides (authored by douardda).
update the growth graph and add a few slides
Jun 27 2019, 11:10 AM
douardda committed rMSLD42c8a4653c01: Add slides for PSES (authored by douardda).
Add slides for PSES
Jun 27 2019, 11:10 AM
Herald added a reviewer for D1651: entrypoints: ensure guncorn services can handle more than one connection: Reviewers.
Jun 27 2019, 10:39 AM

Jun 26 2019

douardda created P451 web app -> 500.
Jun 26 2019, 3:33 PM

Jun 25 2019

douardda accepted D1633: bitbucket: Unify logging instructions.
Jun 25 2019, 1:55 PM · Bitbucket lister, Lister
douardda updated the summary of D1634: lister: Type correctly the 'indexable' column.
Jun 25 2019, 1:51 PM · Bitbucket lister, Lister
douardda added a comment to T1828: Improve directory journal backfill performance.

have we now any insight on the behavior of the backfiller against belvedere?

Jun 25 2019, 9:27 AM · Mirror, Journal
douardda added a comment to T1827: Tweak content backfill order to help content replayer.

I'm enclined to prefer option 2, since performance is an issue we cannot underestimate...

Jun 25 2019, 9:25 AM · Mirror, Journal

Jun 24 2019

douardda requested changes to D1633: bitbucket: Unify logging instructions.

This is not what the commit description says... and is a mix of logging-related refactorings/improvements and code cleanups.

Jun 24 2019, 4:39 PM · Bitbucket lister, Lister
douardda added a comment to D1632: bitbucket: Allow incremental lister to start properly the first time.

Maybe add a line in the commit message about the behavior change of db_partition_indices() (returns an empty list instead of raising a ValueError)

Jun 24 2019, 4:27 PM · Bitbucket lister, Lister
douardda accepted D1632: bitbucket: Allow incremental lister to start properly the first time.

LGTM but I'm biased

Jun 24 2019, 4:26 PM · Bitbucket lister, Lister
douardda accepted D1564: Manipulate origin URLs instead of origin ids..
Jun 24 2019, 3:23 PM
douardda accepted D1636: munin-master: Fix permissions to allow history_counters.json to be updated.
Jun 24 2019, 10:02 AM

Jun 20 2019

douardda updated subscribers of T1826: bitbucket lister does not work.
Jun 20 2019, 11:02 AM · Bitbucket lister, Lister

Jun 19 2019

douardda committed rDJNL693b8f407fb4: cli: add a --concurrency cli option to content-replay (authored by douardda).
cli: add a --concurrency cli option to content-replay
Jun 19 2019, 2:40 PM
douardda committed rDJNL022baee25827: replay: parallelize the copy of objects from a polled set (authored by douardda).
replay: parallelize the copy of objects from a polled set
Jun 19 2019, 2:40 PM
douardda committed rDJNL253d150b5d0b: client: allow to specify any cfg parameter to KafkaConsumer() (authored by douardda).
client: allow to specify any cfg parameter to KafkaConsumer()
Jun 19 2019, 2:40 PM
douardda closed D1608: client: allow to specify any cfg parameter to KafkaConsumer().
Jun 19 2019, 2:40 PM
douardda created P441 comments in pyarc diff.
Jun 19 2019, 2:38 PM
douardda committed rTPYARCd25ba395c37b: Add support for listing comments with diffs (authored by douardda).
Add support for listing comments with diffs
Jun 19 2019, 2:36 PM
douardda committed rTPYARCc55da2739f90: diff: refactor the diff command and improve a bit the rendering (authored by douardda).
diff: refactor the diff command and improve a bit the rendering
Jun 19 2019, 2:36 PM
douardda updated the diff for D1608: client: allow to specify any cfg parameter to KafkaConsumer().

Improve a bit JournalClient's docstring

Jun 19 2019, 2:32 PM
Herald added a reviewer for D1608: client: allow to specify any cfg parameter to KafkaConsumer(): Reviewers.
Jun 19 2019, 10:40 AM

Jun 18 2019

douardda accepted D1563: Refactor the journal client using the new style functions..

"bon d'accord !"

Jun 18 2019, 11:50 AM

Jun 14 2019

douardda committed rDOBJS2b2ac1fc38c8: pathslicing: fix PathSlicingObjStorage.check() method (authored by douardda).
pathslicing: fix PathSlicingObjStorage.check() method
Jun 14 2019, 5:32 PM
douardda committed rDOBJS869fe75ea5eb: tests/pathslicing: add a test for check() that ensure it does work (authored by douardda).
tests/pathslicing: add a test for check() that ensure it does work
Jun 14 2019, 5:32 PM
douardda committed rDOBJSc8e349bf4a94: pathslicing: fix the 'not a gzip' error message in check() (authored by douardda).
pathslicing: fix the 'not a gzip' error message in check()
Jun 14 2019, 5:32 PM
douardda committed rDOBJS605a0b5dfd9c: tests/pathslicing: improve tests for the check() method (authored by douardda).
tests/pathslicing: improve tests for the check() method
Jun 14 2019, 5:32 PM
douardda closed D1587: pathslicing: fix PathSlicingObjStorage.check() method.
Jun 14 2019, 5:32 PM
douardda updated the diff for D1587: pathslicing: fix PathSlicingObjStorage.check() method.

apply vlorentz' suggestions

Jun 14 2019, 4:13 PM
douardda added inline comments to D1587: pathslicing: fix PathSlicingObjStorage.check() method.
Jun 14 2019, 4:10 PM
Herald added a reviewer for D1587: pathslicing: fix PathSlicingObjStorage.check() method: Reviewers.
Jun 14 2019, 3:39 PM
douardda accepted D1581: Add a new origin_visit_get_latest endpoint..
Jun 14 2019, 1:27 PM
douardda accepted D1585: Ignore Hypothesis timeout error for test_add_arbitrary..
Jun 14 2019, 1:25 PM
douardda accepted D1580: Actually run the remote-pg-storage tests on a remote-pg..

LGTM.
Now. what you do not understand "I don't understand why..." Is it "why the code does not behaves how it was intended to?" or "why the code was written so it actually uses a local storage?"

Jun 14 2019, 10:47 AM
douardda requested changes to D1581: Add a new origin_visit_get_latest endpoint..

LGTM but please fix the abstract class's docstring as stated in the comment above.

Jun 14 2019, 10:41 AM

Jun 13 2019

douardda accepted D1579: lister.core: Remove origin creation from lister behavior.
Jun 13 2019, 3:39 PM
douardda requested changes to D1579: lister.core: Remove origin creation from lister behavior.
Jun 13 2019, 2:41 PM
douardda accepted D1573: Use origin URLs instead of numeric ids in the Git loader..
Jun 13 2019, 2:33 PM
douardda added inline comments to D1547: Add test for content_get_range..
Jun 13 2019, 2:30 PM
douardda requested changes to D1564: Manipulate origin URLs instead of origin ids..
Jun 13 2019, 2:26 PM
douardda requested changes to D1563: Refactor the journal client using the new style functions..
Jun 13 2019, 2:20 PM
douardda added inline comments to D1547: Add test for content_get_range..
Jun 13 2019, 2:14 PM
douardda accepted D1544: Add tests for content_missing..
Jun 13 2019, 2:06 PM
douardda committed rDCORE9d6aed3056ba: cli/db: do not attempt to create the DB by default (authored by douardda).
cli/db: do not attempt to create the DB by default
Jun 13 2019, 2:03 PM
douardda closed D1576: cli/db: do not attempt to create the DB by default.
Jun 13 2019, 2:03 PM
douardda accepted D1538: Add test for date parsing of origin_visit_add..
Jun 13 2019, 2:02 PM
douardda accepted D1552: Test date parsing of origin_metadata_add..
Jun 13 2019, 2:01 PM
douardda updated the diff for D1576: cli/db: do not attempt to create the DB by default.

update the docstring

Jun 13 2019, 9:46 AM
Herald added a reviewer for D1576: cli/db: do not attempt to create the DB by default: Reviewers.
Jun 13 2019, 9:45 AM
douardda committed rDSCH237e8c564406: cli: rename a admin cli commands (authored by douardda).
cli: rename a admin cli commands
Jun 13 2019, 9:29 AM
douardda closed D1502: cli: rename a admin cli commands.
Jun 13 2019, 9:29 AM
douardda updated the diff for D1502: cli: rename a admin cli commands.

rebased

Jun 13 2019, 9:29 AM

Jun 12 2019

douardda committed rDJNL71ed469d5769: Bump dependency on swh.storage to v0.0.141 (authored by douardda).
Bump dependency on swh.storage to v0.0.141
Jun 12 2019, 1:49 PM
douardda committed rDJNL88c544ea8aba: cli: do only listen to required kafka topic in content-replay command (authored by douardda).
cli: do only listen to required kafka topic in content-replay command
Jun 12 2019, 1:48 PM
douardda committed rDJNLf86f3baf0903: cli: fix handling of get_journal_client's 'brokers' argument (authored by douardda).
cli: fix handling of get_journal_client's 'brokers' argument
Jun 12 2019, 1:48 PM
douardda committed rDJNL433b85b4bc62: replay: do not crash if process_replay_objects_content() fails on one object (authored by douardda).
replay: do not crash if process_replay_objects_content() fails on one object
Jun 12 2019, 1:48 PM
douardda committed rDJNL7ed426b34a20: JournalClient: change the prefix init argument dafault value to None (authored by douardda).
JournalClient: change the prefix init argument dafault value to None
Jun 12 2019, 1:48 PM
douardda closed D1571: cli: fix brokers argument handling (+ a pile of small refactorings).
Jun 12 2019, 1:48 PM
douardda requested changes to D1552: Test date parsing of origin_metadata_add..

I'm not very fond of testing several things at once. This does not "Test date parsing of origin_metadata_add" as such, it adds this testing as a side effect, in the middle of an unrelated test. Which is not a good idea. I mean, the test is named 'test_origin_metadata_get' and it does already too many things. Having the test named 'test_origin_metadata_get' fail because of bug in parsing dates in origin_metadata_add does not help the poor guy fixing these...

Jun 12 2019, 12:32 PM
douardda accepted D1551: Test that content_find filters out contents that don't match..
Jun 12 2019, 12:27 PM
douardda accepted D1549: Fix key names in the in-mem impl of metadata_provider_{get,add}.
Jun 12 2019, 12:26 PM
douardda accepted D1548: Add a test checking that directory_ls does not recurse into subdirs by default..

It's not that straightforward that this test does indeed do what the commit message pretends... A comment or 2 in the code of the test would not hurt. But meh

Jun 12 2019, 12:24 PM
douardda added inline comments to D1547: Add test for content_get_range..
Jun 12 2019, 12:21 PM
douardda accepted D1546: Add test for content_add when one of the content is already known..
Jun 12 2019, 12:19 PM
douardda accepted D1543: Add test for snapshot_get_branches with both filter and pagination..
Jun 12 2019, 12:18 PM
douardda accepted D1542: Add test for ctime in content_add..
Jun 12 2019, 12:17 PM
douardda accepted D1539: Add origin_visit counter to the in-mem storage + Add test for snapshot/release counters..

Ok, but I would have loved to see a word or 2 explaining why this revision is needed in the commit message.

Jun 12 2019, 12:16 PM
douardda requested changes to D1538: Add test for date parsing of origin_visit_add..
Jun 12 2019, 11:54 AM
douardda accepted D1572: Deploy new listers in production.
Jun 12 2019, 11:43 AM · Lister
douardda updated the diff for D1571: cli: fix brokers argument handling (+ a pile of small refactorings).

log an exception if process_replay_objects_content() fails

Jun 12 2019, 11:42 AM
Herald added a reviewer for D1571: cli: fix brokers argument handling (+ a pile of small refactorings): Reviewers.
Jun 12 2019, 10:56 AM

Jun 11 2019

douardda accepted D1562: Add option object_types to get_journal_client..
Jun 11 2019, 4:31 PM
douardda committed rDSTOd8f0a7b0e5ef: storage: small typo in Storage.content_add_metadata's doc string (authored by douardda).
storage: small typo in Storage.content_add_metadata's doc string
Jun 11 2019, 10:12 AM
douardda committed rDMOD0815880accd0: setup: register the 'identify' cli subcommand (authored by douardda).
setup: register the 'identify' cli subcommand
Jun 11 2019, 10:09 AM
douardda committed rDMODd7ec4a61647a: cli: add support for --help on the 'identify' cli tool (authored by douardda).
cli: add support for --help on the 'identify' cli tool
Jun 11 2019, 10:09 AM
douardda committed rDMOD60c3f7d4fb3d: cli: the 'objects' argument is in fact mandatory (authored by douardda).
cli: the 'objects' argument is in fact mandatory
Jun 11 2019, 10:09 AM
douardda closed D1473: setup: register the 'identify' cli subcommand.
Jun 11 2019, 10:09 AM
douardda updated the diff for D1473: setup: register the 'identify' cli subcommand.

rebase

Jun 11 2019, 10:08 AM

Jun 7 2019

douardda committed rDJNL2cb86247f815: replay: make unexpectedly received object_type log a warning (authored by douardda).
replay: make unexpectedly received object_type log a warning
Jun 7 2019, 4:07 PM
douardda committed rDJNL46db4e82a19b: cli: extract the JournalClient instanciation in a dedicated function (authored by douardda).
cli: extract the JournalClient instanciation in a dedicated function
Jun 7 2019, 4:07 PM
douardda committed rDJNL1e2aa47c931a: Add a content replayer service (authored by douardda).
Add a content replayer service
Jun 7 2019, 4:07 PM
douardda closed D1541: add a content replayer service.
Jun 7 2019, 4:07 PM
douardda committed rDJNLbf0cf9d62dc7: backfill: use consistent 'prefix' config key instead of 'final_prefix' (authored by douardda).
backfill: use consistent 'prefix' config key instead of 'final_prefix'
Jun 7 2019, 4:06 PM
douardda committed rDJNLd2b34040863b: cli: improve the CLI (authored by douardda).
cli: improve the CLI
Jun 7 2019, 4:06 PM
douardda committed rDJNL74998fe39ae6: Ensure a default value for JournalClient's prefix parameter (authored by douardda).
Ensure a default value for JournalClient's prefix parameter
Jun 7 2019, 4:06 PM
douardda committed rDJNLfc174641b95c: client: simplify a bit the JournalClient class (authored by douardda).
client: simplify a bit the JournalClient class
Jun 7 2019, 4:06 PM
douardda committed rDJNLfc0738eb58d4: tests: refactor replayer tests (authored by douardda).
tests: refactor replayer tests
Jun 7 2019, 4:06 PM