Paths

Table of Contentst

Differential D1587

pathslicing: fix PathSlicingObjStorage.check() method
ClosedPublic
Actions

Authored by douardda on Jun 14 2019, 3:39 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDOBJS2b2ac1fc38c8: pathslicing: fix PathSlicingObjStorage.check() method
rDOBJSc8e349bf4a94: pathslicing: fix the 'not a gzip' error message in check()
rDOBJS869fe75ea5eb: tests/pathslicing: add a test for check() that ensure it does work
rDOBJS605a0b5dfd9c: tests/pathslicing: improve tests for the check() method

Summary

it did not work for hex encoded obj_id.

Also:

tests/pathslicing: improve tests for the check() method validate we do have the expected error, namely 'not a gzip' and 'wrong hash id'.

pathslicing: fix the 'not a gzip' error message in check() write the hex obj id in the error message instead of the repr of the bytes.

tests/pathslicing: add a test for check() that ensure it does work we only had tests for non-valid checks.

Fixes test_objstorage_pathslicing.py's test_check_not_gzip.

Fixes test_objstorage_pathslicing.py's test_check_ok.

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jun 14 2019, 3:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 14 2019, 3:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/61/ for more details.

Harbormaster completed remote builds in B6222: Diff 5249.Jun 14 2019, 3:43 PM

vlorentz added a subscriber: vlorentz.Jun 14 2019, 4:03 PM

vlorentz added inline comments.

swh/objstorage/backends/pathslicing.py
274 ↗	(On Diff #5249)	How come both `actual_obj_id.hex()` and `hashutil.hash_to_hex(actual_obj_id)` work?
279 ↗	(On Diff #5249)	Might as well use `hex_obj_id`

douardda added inline comments.Jun 14 2019, 4:10 PM

swh/objstorage/backends/pathslicing.py
274 ↗	(On Diff #5249)	not sure, but let's keep using has_to_hex here, shall we?
279 ↗	(On Diff #5249)	indeed

vlorentz added inline comments.Jun 14 2019, 4:12 PM

swh/objstorage/backends/pathslicing.py
274 ↗	(On Diff #5249)	TIL byte objects have a `.hex()` method.

vlorentz accepted this revision.Jun 14 2019, 4:12 PM

This revision is now accepted and ready to land.Jun 14 2019, 4:12 PM

apply vlorentz' suggestions

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/62/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/62/console

Harbormaster failed remote builds in B6223: Diff 5250!Jun 14 2019, 4:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/63/ for more details.

This revision was landed with ongoing or failed builds.Jun 14 2019, 5:32 PM

Closed by commit rDOBJS605a0b5dfd9c: tests/pathslicing: improve tests for the check() method (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

objstorage/

tests/

test_objstorage_pathslicing.py

14 lines

Diff 5252

swh/objstorage/tests/test_objstorage_pathslicing.py

Loading...