Differential D1573

Use origin URLs instead of numeric ids in the Git loader.
ClosedPublic
Actions

Authored by vlorentz on Jun 12 2019, 3:06 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDLDGb3782ff0fd21: Use origin URLs instead of numeric ids.

Summary

Note that the loader-core still uses origin ids, but it will allow
a smooth migration for the git loader when I'll remove ids from the
loader-core.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 12 2019, 3:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 12 2019, 3:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/70/ for more details.

Harbormaster completed remote builds in B6162: Diff 5189.Jun 12 2019, 3:08 PM

douardda accepted this revision.Jun 13 2019, 2:33 PM

This revision is now accepted and ready to land.Jun 13 2019, 2:33 PM

Closed by commit rDLDGb3782ff0fd21: Use origin URLs instead of numeric ids. (authored by vlorentz). · Explain WhyJun 13 2019, 2:52 PM

This revision was automatically updated to reflect the committed changes.

vlorentz mentioned this in T1816: Make all clients of swh-storage use origin URL as identifier and use visit types instead of origin types.Jun 17 2019, 4:20 PM

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

converters.py

4 lines

from_disk.py

10 lines

loader.py

40 lines

Diff 5222

View Options

swh/loader/git/converters.py

View Options

swh/loader/git/from_disk.py

View Options

Use origin URLs instead of numeric ids in the Git loader.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5222

swh/loader/git/converters.py

swh/loader/git/from_disk.py

swh/loader/git/loader.py

Use origin URLs instead of numeric ids in the Git loader.
ClosedPublic
Actions

Revision Contents
Changeset List