Page MenuHomeSoftware Heritage

Fix key names in the in-mem impl of metadata_provider_{get,add}
Needs ReviewPublic

Authored by vlorentz on Wed, Jun 5, 1:35 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers

Diff Detail

Repository
rDSTO Storage manager
Branch
test-metadata_provider_add
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6256
Build 8653: tox-on-jenkinsJenkins
Build 8652: arc lint + arc unit

Event Timeline

vlorentz created this revision.Wed, Jun 5, 1:35 PM
douardda accepted this revision.Wed, Jun 12, 12:26 PM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/storage/tests/test_storage.py
3573

why not call it with **provider?

This revision is now accepted and ready to land.Wed, Jun 12, 12:26 PM
vlorentz added inline comments.Wed, Jun 12, 1:20 PM
swh/storage/tests/test_storage.py
3573

Because the argument names are provider_name, provider_type, and provider_url. I plan on changing that when D1509 is accepted.

vlorentz updated this revision to Diff 5277.Mon, Jun 17, 1:51 PM
  • fix in-mem code
  • rebase
vlorentz requested review of this revision.Mon, Jun 17, 1:52 PM
vlorentz retitled this revision from Add a test for metadata_provider_add/get. to Fix key names in the in-mem impl of metadata_provider_{get,add}.
vlorentz updated this revision to Diff 5278.Mon, Jun 17, 2:08 PM

fix in-mem