Details

Reviewers

Group Reviewers

Commits

rDSTOC4696160a7d53: Fix key names in the in-mem impl of metadata_provider_{get,add}
rDSTO4696160a7d53: Fix key names in the in-mem impl of metadata_provider_{get,add}

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 5 2019, 1:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2019, 1:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/446/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/446/console

Harbormaster failed remote builds in B6032: Diff 5085!Jun 5 2019, 2:09 PM

douardda accepted this revision.Jun 12 2019, 12:26 PM

douardda added a subscriber: douardda.

douardda added inline comments.

swh/storage/tests/test_storage.py
3572	why not call it with `**provider`?

This revision is now accepted and ready to land.Jun 12 2019, 12:26 PM

vlorentz added inline comments.Jun 12 2019, 1:20 PM

swh/storage/tests/test_storage.py
3572	Because the argument names are `provider_name`, `provider_type`, and `provider_url`. I plan on changing that when D1509 is accepted.

fix in-mem code
rebase

vlorentz requested review of this revision.Jun 17 2019, 1:52 PM

vlorentz retitled this revision from Add a test for metadata_provider_add/get. to Fix key names in the in-mem impl of metadata_provider_{get,add}.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/497/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/497/console

Harbormaster failed remote builds in B6255: Diff 5277!Jun 17 2019, 2:01 PM

fix in-mem

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/498/ for more details.

Harbormaster completed remote builds in B6256: Diff 5278.Jun 17 2019, 2:20 PM

rebase

This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2019, 11:18 AM

This revision was landed with ongoing or failed builds.

Closed by commit rDSTO4696160a7d53: Fix key names in the in-mem impl of metadata_provider_{get,add} (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6437: Diff 5450!Jun 24 2019, 11:19 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/508/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/508/console

Harbormaster failed remote builds in B6438: Diff 5451!Jun 24 2019, 11:19 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/509/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/509/console

Fix key names in the in-mem impl of metadata_provider_{get,add}
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5452

swh/storage/in_memory.py

swh/storage/tests/test_storage.py

Fix key names in the in-mem impl of metadata_provider_{get,add}ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5452

swh/storage/in_memory.py

swh/storage/tests/test_storage.py

Fix key names in the in-mem impl of metadata_provider_{get,add}
ClosedPublic
Actions

Revision Contents
Changeset List