Page MenuHomeSoftware Heritage

Fix key names in the in-mem impl of metadata_provider_{get,add}
ClosedPublic

Authored by vlorentz on Jun 5 2019, 1:35 PM.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 5 2019, 1:35 PM
douardda accepted this revision.Jun 12 2019, 12:26 PM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/storage/tests/test_storage.py
3573

why not call it with **provider?

This revision is now accepted and ready to land.Jun 12 2019, 12:26 PM
vlorentz added inline comments.Jun 12 2019, 1:20 PM
swh/storage/tests/test_storage.py
3573

Because the argument names are provider_name, provider_type, and provider_url. I plan on changing that when D1509 is accepted.

vlorentz updated this revision to Diff 5277.Jun 17 2019, 1:51 PM
  • fix in-mem code
  • rebase
vlorentz requested review of this revision.Jun 17 2019, 1:52 PM
vlorentz retitled this revision from Add a test for metadata_provider_add/get. to Fix key names in the in-mem impl of metadata_provider_{get,add}.
vlorentz updated this revision to Diff 5278.Jun 17 2019, 2:08 PM

fix in-mem

This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2019, 11:18 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.