Page MenuHomeSoftware Heritage

Actually run the remote-pg-storage tests on a remote-pg.
ClosedPublic

Authored by vlorentz on Jun 13 2019, 4:28 PM.

Details

Summary

They were run on a local pg instead of via the HTTP API.

I don't understand why...

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 13 2019, 4:28 PM
douardda accepted this revision.Jun 14 2019, 10:47 AM
douardda added a subscriber: douardda.

LGTM.
Now. what you do not understand "I don't understand why..." Is it "why the code does not behaves how it was intended to?" or "why the code was written so it actually uses a local storage?"

swh/storage/tests/test_api_client.py
60

This was done like this before this diff, but I don't really understand why we need to keep a ref on app as a member of the instance...

This revision is now accepted and ready to land.Jun 14 2019, 10:47 AM

Is it "why the code does not behaves how it was intended to?"

This one. The line self.storage = RemoteStorage(self.url()) was not run.

This revision was automatically updated to reflect the committed changes.