Differential D1576

cli/db: do not attempt to create the DB by default
ClosedPublic
Actions

Authored by douardda on Jun 13 2019, 9:45 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE9d6aed3056ba: cli/db: do not attempt to create the DB by default

Summary

this is needed to prevent the command to depend on having pg's createdb
tool installed on the machine running the 'swh db-init' command.

In a normal deployment setup, this pg tool is not expected to be present
on every machine on which one want to be able to use this 'swh db-init'
command.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jun 13 2019, 9:45 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 13 2019, 9:45 AM

update the docstring

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/226/ for more details.

Harbormaster completed remote builds in B6179: Diff 5206.Jun 13 2019, 9:48 AM

Harbormaster completed remote builds in B6180: Diff 5207.Jun 13 2019, 9:51 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/228/ for more details.

Sounds a more sensible default indeed.

This revision is now accepted and ready to land.Jun 13 2019, 9:58 AM

Closed by commit rDCORE9d6aed3056ba: cli/db: do not attempt to create the DB by default (authored by douardda). · Explain WhyJun 13 2019, 2:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

core/

cli/

db.py

12 lines

Diff 5212

View Options

cli/db: do not attempt to create the DB by defaultClosedPublicActions