Page MenuHomeSoftware Heritage
Differential D1633

bitbucket: Unify logging instructions
ClosedPublic
Actions

Authored by ardumont on Jun 23 2019, 9:32 AM.

Details

Reviewers
olasd
douardda
Group Reviewers
Reviewers
Commits
rDLS45428c25dffa: bitbucket: Unify logging instructions
Summary

As the title said, i had to log stuff around to make sense of what happened.
In the end, might as well unify a bit.

Depends on D1632

Test Plan

tox

Diff Detail

Repository
rDLS Listers
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 23 2019, 9:32 AM
ardumont mentioned this in D1634: lister: Type correctly the 'indexable' column.Jun 23 2019, 9:33 AM
ardumont added projects: Lister, Bitbucket lister.
swh-public-ci added a comment.Jun 23 2019, 9:38 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/227/ for more details.

Harbormaster completed remote builds in B6427: Diff 5439.Jun 23 2019, 9:38 AM
ardumont updated this revision to Diff 5458.Jun 24 2019, 4:25 PM

Update after amending commits

ardumont updated this revision to Diff 5459.Jun 24 2019, 4:27 PM

Fix to use the right range of commits...

swh-public-ci added a comment.Jun 24 2019, 4:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/239/ for more details.

Harbormaster completed remote builds in B6445: Diff 5458.Jun 24 2019, 4:30 PM
ardumont updated this revision to Diff 5461.Jun 24 2019, 4:33 PM

Rebase and amend properly the diff

@douardda my command was using --update twice so that did not do what i thought ;)

swh-public-ci added a comment.Jun 24 2019, 4:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/240/ for more details.

Harbormaster completed remote builds in B6446: Diff 5459.Jun 24 2019, 4:34 PM
douardda requested changes to this revision.Jun 24 2019, 4:39 PM

This is not what the commit description says... and is a mix of logging-related refactorings/improvements and code cleanups.

This revision now requires changes to proceed.Jun 24 2019, 4:39 PM
swh-public-ci added a comment.Jun 24 2019, 4:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/242/ for more details.

Harbormaster completed remote builds in B6448: Diff 5461.Jun 24 2019, 4:45 PM
ardumont updated this revision to Diff 5468.Jun 24 2019, 6:04 PM

Remove refactoring part

swh-public-ci added a comment.Jun 24 2019, 6:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/247/ for more details.

Harbormaster completed remote builds in B6458: Diff 5468.Jun 24 2019, 6:08 PM
douardda added a child revision: D1634: lister: Type correctly the 'indexable' column.Jun 25 2019, 1:51 PM
douardda accepted this revision.Jun 25 2019, 1:55 PM
This revision is now accepted and ready to land.Jun 25 2019, 1:55 PM
ardumont updated this revision to Diff 5479.Jun 25 2019, 2:23 PM

Update following interactive rebase (+ update some logging instruction changes)

swh-public-ci added a comment.Jun 25 2019, 2:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/255/ for more details.

Harbormaster completed remote builds in B6469: Diff 5479.Jun 25 2019, 2:28 PM
ardumont added a child revision: D1638: lister: Clean up code.Jun 25 2019, 2:30 PM
ardumont removed a parent revision: D1632: bitbucket: Allow incremental lister to start properly the first time.Jun 25 2019, 2:36 PM
ardumont removed a child revision: D1634: lister: Type correctly the 'indexable' column.Jun 25 2019, 2:40 PM
Closed by commit rDLS45428c25dffa: bitbucket: Unify logging instructions (authored by ardumont). · Explain WhyJun 26 2019, 11:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
lister/
bitbucket/
2 lines
core/
5 lines

Diff 5500

View Options

swh/lister/bitbucket/tasks.py

Loading...
View Options

swh/lister/core/indexing_lister.py

Loading...
About · Developer information · Legal