Page MenuHomeSoftware Heritage
Differential D1563

Refactor the journal client using the new style functions.
ClosedPublic
Actions

Authored by vlorentz on Jun 7 2019, 4:15 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDCIDXe621519cc70d: Refactor the journal client using the new style functions.
Summary

Depends on this swh-journal diff: D1563

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 7 2019, 4:15 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 7 2019, 4:15 PM
swh-public-ci added a comment.Jun 7 2019, 4:18 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/541/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/541/console

Harbormaster failed remote builds in B6107: Diff 5149!Jun 7 2019, 4:18 PM
vlorentz edited the summary of this revision. (Show Details)Jun 7 2019, 4:24 PM
vlorentz updated this revision to Diff 5152.Jun 7 2019, 4:32 PM

bump dep on swh-journal.

swh-public-ci added a comment.Jun 7 2019, 4:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/544/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/544/console

Harbormaster failed remote builds in B6110: Diff 5152!Jun 7 2019, 4:34 PM
vlorentz mentioned this in D1562: Add option object_types to get_journal_client..Jun 11 2019, 4:30 PM
douardda requested changes to this revision.Jun 13 2019, 2:20 PM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/indexer/cli.py
185

What is this new command supposed to do? Shouldn't it come with a usage/description (docstring)? Is journal-client a good name for it?

This revision now requires changes to proceed.Jun 13 2019, 2:20 PM
vlorentz updated this revision to Diff 5232.Jun 14 2019, 10:33 AM

add docstring.

swh/indexer/cli.py
185

I couldn't find a better name. Suggestions welcome.

swh-public-ci added a comment.Jun 14 2019, 10:37 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/547/ for more details.

Harbormaster completed remote builds in B6206: Diff 5232.Jun 14 2019, 10:37 AM
douardda accepted this revision.Jun 18 2019, 11:50 AM

"bon d'accord !"

This revision is now accepted and ready to land.Jun 18 2019, 11:50 AM
Closed by commit rDCIDXe621519cc70d: Refactor the journal client using the new style functions. (authored by vlorentz). · Explain WhyJun 18 2019, 11:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
swh/
indexer/
55 lines
102 lines
tests/
57 lines
42 lines

Diff 5293

View Options

requirements-swh.txt

Loading...
View Options

swh/indexer/cli.py

Loading...
View Options

swh/indexer/journal_client.py

Loading...
View Options

swh/indexer/tests/test_cli.py

Loading...
View Options

swh/indexer/tests/test_journal_client.py

Loading...
About · Developer information · Legal