Page MenuHomeSoftware Heritage
Feed All Stories

Nov 2 2022

vlorentz committed rDCIDX41e90e4ae6f2: codemeta: Fix crash on SWORD documents that specify an id (authored by vlorentz).
codemeta: Fix crash on SWORD documents that specify an id
Nov 2 2022, 5:42 PM
ardumont accepted D8801: cpan: Add extid manifest to CpanPackageInfo.
Nov 2 2022, 5:38 PM
douardda accepted D8634: Prepare the tests to run in Jenkins.
Nov 2 2022, 5:37 PM
swh-public-ci added a comment to D8801: cpan: Add extid manifest to CpanPackageInfo.

Build is green

Nov 2 2022, 5:23 PM
anlambert retitled D8801: cpan: Add extid manifest to CpanPackageInfo from cpan: Implement CpanPackageInfo.extid to cpan: Add extid manifest to CpanPackageInfo.
Nov 2 2022, 5:20 PM
anlambert updated the diff for D8801: cpan: Add extid manifest to CpanPackageInfo.

Update: Prefer to use an extid manifest instead of simply using sha256 checksum as it seems more robust.

Nov 2 2022, 5:20 PM
vsellier abandoned D8645: azure: create the production environment for gitlab.

migrated to gitlab MR https://gitlab.softwareheritage.org/infra/swh-sysadmin-provisioning/-/merge_requests/88

Nov 2 2022, 5:16 PM
swh-public-ci added a comment to D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.

Build is green

Nov 2 2022, 5:02 PM
anlambert accepted D8569: Add rubygems loader.

Looks good to me, thanks !

Nov 2 2022, 4:58 PM
douardda committed rDPROVe4795882d3aa: sql: only insert entities that we really need to insert in relation_add (authored by douardda).
sql: only insert entities that we really need to insert in relation_add
Nov 2 2022, 4:56 PM
douardda committed rDPROVc89763f01c8d: tests: set journal writer auto_flush to False (authored by douardda).
tests: set journal writer auto_flush to False
Nov 2 2022, 4:56 PM
douardda closed D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.
Nov 2 2022, 4:56 PM
douardda committed rDPROV90a4250a2c57: tests: simplify and (possibly) fix the grpc_server helper context manager (authored by douardda).
tests: simplify and (possibly) fix the grpc_server helper context manager
Nov 2 2022, 4:56 PM
douardda updated the diff for D8696: tests: simplify and (possibly) fix the grpc_server helper context manager.

also add rabbitmq marker in pytest.ini

Nov 2 2022, 4:55 PM
anlambert requested review of D8801: cpan: Add extid manifest to CpanPackageInfo.
Nov 2 2022, 4:40 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8801: cpan: Add extid manifest to CpanPackageInfo.
Nov 2 2022, 4:36 PM · CPAN lister, Archive coverage
swh-public-ci added a comment to D8569: Add rubygems loader.

Build is green

Nov 2 2022, 4:28 PM
franckbret updated the diff for D8569: Add rubygems loader.

Do not json.loads already deserialized json data

Nov 2 2022, 4:24 PM
vsellier abandoned D8617: thanos: Declare archive-production thanos for live data querying.

migrated to https://gitlab.softwareheritage.org/infra/puppet/puppet-swh-site/-/merge_requests/533

Nov 2 2022, 3:16 PM
olasd added inline comments to D8760: Add payloads to ExtIDs.
Nov 2 2022, 2:39 PM
ardumont added inline comments to D8799: codemeta: Fix crash on SWORD documents that specify an id.
Nov 2 2022, 2:25 PM
anlambert triaged T4669: Add support to browse snapshot branches targeting contents or directories as Normal priority.
Nov 2 2022, 1:50 PM · Web app
swh-public-ci added a comment to D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

Build is green

Nov 2 2022, 1:37 PM
anlambert updated the diff for D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

Address @vlorentz comments

Nov 2 2022, 1:28 PM
anlambert added inline comments to D8798: save_origin_webhooks: Add push webhook receivers for popular forges.
Nov 2 2022, 1:27 PM
olasd accepted D8799: codemeta: Fix crash on SWORD documents that specify an id.

Thanks!

Nov 2 2022, 1:22 PM
swh-public-ci added a comment to D8799: codemeta: Fix crash on SWORD documents that specify an id.

Build is green

Nov 2 2022, 1:11 PM
vlorentz updated the diff for D8799: codemeta: Fix crash on SWORD documents that specify an id.

add logging

Nov 2 2022, 1:07 PM
olasd added inline comments to D8799: codemeta: Fix crash on SWORD documents that specify an id.
Nov 2 2022, 12:55 PM
vlorentz added inline comments to D8777: Puppet: Lister implements incremental mode.
Nov 2 2022, 12:21 PM
vlorentz added inline comments to D8777: Puppet: Lister implements incremental mode.
Nov 2 2022, 12:18 PM
vlorentz added a comment to D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

I just did a proper review now, it still looks good :)

Nov 2 2022, 12:10 PM
swh-public-ci added a comment to D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

Build is green

Nov 2 2022, 12:01 PM
anlambert updated the diff for D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

Update: Simplify implementation using classes (thanks to @vlorentz)

Nov 2 2022, 11:52 AM
vlorentz closed T4660: Workaround / in tree entry names as Resolved.
Nov 2 2022, 11:52 AM · Git loader
vlorentz closed T4660: Workaround / in tree entry names, a subtask of T4659: Fix all crashes of the git loader caused by malformed git objects, as Resolved.
Nov 2 2022, 11:52 AM · meta-task, Git loader
vlorentz added a comment to T4599: Github descriptions are not used to search origins.

Now depends on https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4658 instead

Nov 2 2022, 11:51 AM · Metadata workflow, Archive search
vlorentz closed T4656: AttributeError: 'NoneType' object has no attribute 'endswith' as Resolved.
Nov 2 2022, 11:50 AM · Indexer
vlorentz closed Restricted Maniphest Task, a subtask of T2073: Index extrinsic metadata from the journal in swh-search/Elasticsearch, as Resolved.
Nov 2 2022, 11:50 AM · Archive search, Metadata workflow
vlorentz closed T4637: Document/showcase examples gRPC clients of the swh-graph as Resolved.
Nov 2 2022, 11:49 AM · Documentation, Compressed graph service
anlambert added a comment to D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

Thanks, I like it.

Before going into the details, what do you think of D8800? it's a refactoring of this diff, using an abstract OriginSaveWebhookReceiver class, and each forge defines a subclass. This replaces calls to origin_save_webhook_receiver with lots of arguments and decorators. I didn't touch the tests at all.

Nov 2 2022, 11:45 AM
vlorentz closed T4654: swh-indexer produces dates not supported by swh-search/ElasticSearch as Resolved.
Nov 2 2022, 11:43 AM · Archive search, Indexer
vlorentz removed a parent task for T2183: Switch webapp0 to use swh-search instead of postgresql search.: T2185: Make webapp0 use Cassandra as storage backend..
Nov 2 2022, 11:34 AM · Archive search, Storage manager
vlorentz removed a subtask for T2185: Make webapp0 use Cassandra as storage backend.: T2183: Switch webapp0 to use swh-search instead of postgresql search..
Nov 2 2022, 11:34 AM · Storage manager
vlorentz added a comment to T2183: Switch webapp0 to use swh-search instead of postgresql search..

(detaching this task from the Cassandra task tree, because it's getting really big)

Nov 2 2022, 11:33 AM · Archive search, Storage manager
vlorentz removed a subtask for T1892: Cassandra as a storage backend: T1910: Redesign origin search using a dedicated component (swh-search).
Nov 2 2022, 11:33 AM · meta-task, Storage manager
vlorentz removed a parent task for T1910: Redesign origin search using a dedicated component (swh-search): T1892: Cassandra as a storage backend.
Nov 2 2022, 11:33 AM · Archive search, Storage manager
vlorentz added a comment to T1910: Redesign origin search using a dedicated component (swh-search).

(detaching this task from the Cassandra task tree, because it's getting really big)

Nov 2 2022, 11:33 AM · Archive search, Storage manager
vlorentz added a subtask for T2033: Run Cassandra storage backend with production data: T4668: replayer: Crashes because of directories with duplicated entry names in journal.
Nov 2 2022, 11:32 AM · Storage manager
vlorentz added a parent task for T4668: replayer: Crashes because of directories with duplicated entry names in journal: T2033: Run Cassandra storage backend with production data.
Nov 2 2022, 11:32 AM · Data Model, Journal
vlorentz added a comment to T4668: replayer: Crashes because of directories with duplicated entry names in journal.

New objects with duplicated entries go through this method to be fixed: https://docs.softwareheritage.org/devel/apidoc/swh.model.model.html#swh.model.model.Directory.from_possibly_duplicated_entries (currently only used by swh.storage.backfill); but old kafka messages still have duplicate entries, causing the crash above.

Nov 2 2022, 11:20 AM · Data Model, Journal
vlorentz placed T4668: replayer: Crashes because of directories with duplicated entry names in journal up for grabs.
Nov 2 2022, 11:17 AM · Data Model, Journal
swh-sentry-integration assigned T4668: replayer: Crashes because of directories with duplicated entry names in journal to vlorentz.
Nov 2 2022, 11:17 AM · Data Model, Journal
vlorentz added a comment to D8798: save_origin_webhooks: Add push webhook receivers for popular forges.

Thanks, I like it.

Nov 2 2022, 10:27 AM
vlorentz requested review of D8799: codemeta: Fix crash on SWORD documents that specify an id.
Nov 2 2022, 9:39 AM
vlorentz added a revision to T4667: JsonLdError: ('Invalid JSON-LD syntax; "@id" value must be a string.',): D8799: codemeta: Fix crash on SWORD documents that specify an id.
Nov 2 2022, 9:35 AM · Indexer
vlorentz triaged T4667: JsonLdError: ('Invalid JSON-LD syntax; "@id" value must be a string.',) as Normal priority.
Nov 2 2022, 9:29 AM · Indexer
swh-sentry-integration assigned T4667: JsonLdError: ('Invalid JSON-LD syntax; "@id" value must be a string.',) to vlorentz.
Nov 2 2022, 9:28 AM · Indexer
franckbret added a comment to D8569: Add rubygems loader.

Rubygems: Improve loader to make use of artifacts and rubygems_metadata provided by the lister extra_loader_arguments

Use artifacts and rubygems_metadata to get list of versions, artifacts checksums and extrinsic metadata url
Add an EXTID manifest
Add metadata from extrinsic metadata

@anlambert Please note I used 'rubygems_metadata' instead of 'rubygem_metadata' as in the lister. Maybe I'm wrong but I think the lister should rename to rubygems_metadata?

@franckbret, I did not use plural because we are processing a single gem in the loader (with multiple versions but those are metadata for a single gem).
So I do not think we should modify the lister output.

Nov 2 2022, 9:06 AM
vlorentz created P1519 gpgsig spoof.
Nov 2 2022, 8:11 AM

Oct 31 2022

anlambert requested review of D8798: save_origin_webhooks: Add push webhook receivers for popular forges.
Oct 31 2022, 7:26 PM
Harbormaster failed to build B32656: rDWAPPS024da72220d4: apidoc: Fix some issues regarding generated documentation links for rDWAPPS024da72220d4: apidoc: Fix some issues regarding generated documentation links!
Oct 31 2022, 5:27 PM
anlambert added a revision to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook: D8798: save_origin_webhooks: Add push webhook receivers for popular forges.
Oct 31 2022, 5:14 PM · Web app
anlambert closed D8795: apidoc: Fix some issues regarding generated documentation links.
Oct 31 2022, 5:14 PM
anlambert committed rDWAPPS024da72220d4: apidoc: Fix some issues regarding generated documentation links (authored by anlambert).
apidoc: Fix some issues regarding generated documentation links
Oct 31 2022, 5:14 PM
ardumont accepted D8795: apidoc: Fix some issues regarding generated documentation links.
Oct 31 2022, 5:12 PM
anlambert requested review of D8795: apidoc: Fix some issues regarding generated documentation links.
Oct 31 2022, 5:09 PM
anlambert closed D8796: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 4:59 PM
anlambert added a reverting change for D8782: templates/stage-cypress-tests: Prevent race condition with support file: rCJSWH2b9d03c3c50d: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 4:59 PM
anlambert added a reverting change for rCJSWHa0fd3dc0fe59: templates/stage-cypress-tests: Prevent race condition with support file: rCJSWH2b9d03c3c50d: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 4:59 PM
anlambert committed rCJSWH2b9d03c3c50d: Revert "templates/stage-cypress-tests: Prevent race condition with support file" (authored by anlambert).
Revert "templates/stage-cypress-tests: Prevent race condition with support file"
Oct 31 2022, 4:58 PM
ardumont accepted D8796: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 4:17 PM
anlambert requested review of D8796: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 3:36 PM
anlambert added a reverting change for rCJSWHa0fd3dc0fe59: templates/stage-cypress-tests: Prevent race condition with support file: D8796: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 3:36 PM
anlambert added a reverting change for D8782: templates/stage-cypress-tests: Prevent race condition with support file: D8796: Revert "templates/stage-cypress-tests: Prevent race condition with support file".
Oct 31 2022, 3:36 PM
anlambert closed D8793: replay: Ensure copyfrom operations are properly handled.
Oct 31 2022, 3:16 PM
anlambert closed D8787: loader: Compress dump file and rework truncated dump handling.
Oct 31 2022, 3:16 PM
anlambert committed rDLDSVN04566a7f3616: replay: Ensure copyfrom operations are properly handled (authored by anlambert).
replay: Ensure copyfrom operations are properly handled
Oct 31 2022, 3:16 PM
anlambert committed rDLDSVNd24ba1a5ccd6: loader: Compress dump file and rework truncated dump handling (authored by anlambert).
loader: Compress dump file and rework truncated dump handling
Oct 31 2022, 3:16 PM
anlambert closed D8786: svn: Ensure to quote URLs provided as parameters to client methods.
Oct 31 2022, 3:16 PM
anlambert committed rDLDSVNc6d39b7bb70b: svn: Ensure to quote URLs provided as parameters to client methods (authored by anlambert).
svn: Ensure to quote URLs provided as parameters to client methods
Oct 31 2022, 3:16 PM
swh-public-ci added a comment to D8793: replay: Ensure copyfrom operations are properly handled.

Build is green

Oct 31 2022, 3:11 PM
swh-public-ci added a comment to D8787: loader: Compress dump file and rework truncated dump handling.

Build is green

Oct 31 2022, 3:10 PM
anlambert updated the diff for D8793: replay: Ensure copyfrom operations are properly handled.

Rebase

Oct 31 2022, 3:06 PM
anlambert updated the diff for D8787: loader: Compress dump file and rework truncated dump handling.

Update: Address @ardumont and @vlorentz comments

Oct 31 2022, 3:06 PM
anlambert closed D8792: docker/conf/nginx: Remove no longer needed proxy and fix formatting.
Oct 31 2022, 3:00 PM
anlambert committed rDENVa4d7bc47b333: docker/conf/nginx: Remove no longer needed proxy and fix formatting (authored by anlambert).
docker/conf/nginx: Remove no longer needed proxy and fix formatting
Oct 31 2022, 3:00 PM
anlambert closed D8791: docker/nginx: Align objstorage proxy_read_timeout value with production.
Oct 31 2022, 3:00 PM
anlambert committed rDENVa30908c7a1f4: docker/nginx: Align objstorage proxy_read_timeout value with production (authored by anlambert).
docker/nginx: Align objstorage proxy_read_timeout value with production
Oct 31 2022, 3:00 PM
ardumont updated subscribers of D8760: Add payloads to ExtIDs.
Oct 31 2022, 2:54 PM
ardumont added a comment to D8760: Add payloads to ExtIDs.

It looks like the changes fail because CI doesn't know to use the model updates in D8759.

Oct 31 2022, 2:49 PM
ardumont accepted D8793: replay: Ensure copyfrom operations are properly handled.
Oct 31 2022, 2:38 PM
ardumont accepted D8787: loader: Compress dump file and rework truncated dump handling.

one non-blocking suggestion to explicit the compressed nature of the dump inline.

Oct 31 2022, 2:21 PM
ardumont accepted D8786: svn: Ensure to quote URLs provided as parameters to client methods.
Oct 31 2022, 2:13 PM
ardumont accepted D8791: docker/nginx: Align objstorage proxy_read_timeout value with production.
Oct 31 2022, 2:08 PM
ardumont accepted D8792: docker/conf/nginx: Remove no longer needed proxy and fix formatting.
Oct 31 2022, 2:08 PM
vlorentz added a comment to T2309: Add support for other hash algo than sha1 in current objstorage implementation.

Possibly relevant for the Azure storage: https://learn.microsoft.com/en-us/rest/api/storageservices/find-blobs-by-tags

Oct 31 2022, 1:50 PM · Object storage
anlambert closed D8794: converters, dumb: Fix errors since latest dulwich release (0.20.50).
Oct 31 2022, 1:20 PM
anlambert committed rDLDGd6d5ce2b58ae: converters, dumb: Fix errors since latest dulwich release (0.20.50) (authored by anlambert).
converters, dumb: Fix errors since latest dulwich release (0.20.50)
Oct 31 2022, 1:19 PM
ardumont accepted D8794: converters, dumb: Fix errors since latest dulwich release (0.20.50).
Oct 31 2022, 12:16 PM