Differential D8801

cpan: Add extid manifest to CpanPackageInfo
ClosedPublic
Actions

Authored by anlambert on Nov 2 2022, 4:36 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2833: cpan.loader - archive Perl modules from CPAN

Commits

rDLDBASEbf2cb039d5d7: cpan: Add extid manifest to CpanPackageInfo

Summary

It enables to avoid downloading and processing a release archive for
a CPAN module if it has already been archived by Software Heritage.

Related to T2833

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 2 2022, 4:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 2 2022, 4:36 PM

Build is green

Patch application report for D8801 (id=31717)

Rebasing onto e6847f3616...

Current branch diff-target is up to date.

Changes applied before test

commit 458d67e37e6d0b77c83f4c504bad19816741e377
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 2 16:29:04 2022 +0100

    cpan: Implement CpanPackageInfo.extid
    
    As each release artifact info for a CPAN module provided as loader argument
    is guaranteed to contain the sha256 checksum of the associated archive to
    download (as the CPAN lister discards artifacts with no checksum info),
    we can use that checksum as extid.
    
    It enables to avoid downloading and processing a release archive if it has
    already been archived by Software Heritage.
    
    Related to T2833

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/1012/ for more details.

Harbormaster completed remote builds in B32666: Diff 31717.Nov 2 2022, 4:40 PM

anlambert requested review of this revision.Nov 2 2022, 4:40 PM

Update: Prefer to use an extid manifest instead of simply using sha256 checksum as it seems more robust.

anlambert retitled this revision from cpan: Implement CpanPackageInfo.extid to cpan: Add extid manifest to CpanPackageInfo.Nov 2 2022, 5:20 PM

anlambert edited the summary of this revision. (Show Details)

Build is green

Patch application report for D8801 (id=31720)

Rebasing onto e6847f3616...

Current branch diff-target is up to date.

Changes applied before test

commit 981a8d58cc06d3005ecf29715280616f86d61a41
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 2 16:29:04 2022 +0100

    cpan: Add extid manifest to CpanPackageInfo
    
    It enables to avoid downloading and processing a release archive for
    a CPAN module if it has already been archived by Software Heritage.
    
    Related to T2833

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/1013/ for more details.

Harbormaster completed remote builds in B32671: Diff 31720.Nov 2 2022, 5:23 PM

ardumont accepted this revision.Nov 2 2022, 5:38 PM

This revision is now accepted and ready to land.Nov 2 2022, 5:38 PM

Rebase

Build is green

Patch application report for D8801 (id=31728)

Rebasing onto 8e34a6d779...

Current branch diff-target is up to date.

Changes applied before test

commit bf2cb039d5d7ad2877d01a32f2c354b375e9aead
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 2 16:29:04 2022 +0100

    cpan: Add extid manifest to CpanPackageInfo
    
    It enables to avoid downloading and processing a release archive for
    a CPAN module if it has already been archived by Software Heritage.
    
    Related to T2833

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/1016/ for more details.

Harbormaster completed remote builds in B32682: Diff 31728.Nov 3 2022, 10:52 AM

Closed by commit rDLDBASEbf2cb039d5d7: cpan: Add extid manifest to CpanPackageInfo (authored by anlambert). · Explain WhyNov 3 2022, 10:53 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASEbf2cb039d5d7: cpan: Add extid manifest to CpanPackageInfo.