Differential D8794

converters, dumb: Fix errors since latest dulwich release (0.20.50)
ClosedPublic
Actions

Authored by anlambert on Oct 31 2022, 11:49 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDGd6d5ce2b58ae: converters, dumb: Fix errors since latest dulwich release (0.20.50)

Summary

ShaFile.get_type was deprecated and has been removed.

New typings have been added in dulwich that trigerred a new mypy error.

See https://jenkins.softwareheritage.org/job/DENV/job/tests/3220/artifact/swh-loader-git.log

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 31 2022, 11:49 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 31 2022, 11:49 AM

Build is green

Patch application report for D8794 (id=31694)

Rebasing onto 44f70a704e...

Current branch diff-target is up to date.

Changes applied before test

commit d6d5ce2b58ae49a8cd458697b2e80f02ef83a472
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 31 11:46:07 2022 +0100

    converters, dumb: Fix errors since latest dulwich release (0.20.50)
    
    ShaFile.get_type was deprecated and has been removed.
    
    New typings have been added in dulwich that trigerred a new mypy error.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/232/ for more details.

Harbormaster completed remote builds in B32646: Diff 31694.Oct 31 2022, 11:51 AM

anlambert requested review of this revision.Oct 31 2022, 11:51 AM

ardumont accepted this revision.Oct 31 2022, 12:16 PM

This revision is now accepted and ready to land.Oct 31 2022, 12:16 PM

Closed by commit rDLDGd6d5ce2b58ae: converters, dumb: Fix errors since latest dulwich release (0.20.50) (authored by anlambert). · Explain WhyOct 31 2022, 1:20 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDGd6d5ce2b58ae: converters, dumb: Fix errors since latest dulwich release (0.20.50).