Page MenuHomeSoftware Heritage

codemeta: Fix crash on SWORD documents that specify an id
ClosedPublic

Authored by vlorentz on Wed, Nov 2, 9:35 AM.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8799 (id=31710)

Rebasing onto 3bad41489c...

Current branch diff-target is up to date.
Changes applied before test
commit e113b61a94aaedb59a0f614ba816268126e65839
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 2 09:35:05 2022 +0100

    codemeta: Fix crash on SWORD documents that specify an id

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/522/ for more details.

olasd added inline comments.
swh/indexer/metadata_dictionary/codemeta.py
113

Shouldn't this spit a warning of some sort?

vlorentz marked an inline comment as done.

add logging

Build is green

Patch application report for D8799 (id=31714)

Rebasing onto 3bad41489c...

Current branch diff-target is up to date.
Changes applied before test
commit 41e90e4ae6f212fe76be71bd8904a7e8a10daca4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 2 09:35:05 2022 +0100

    codemeta: Fix crash on SWORD documents that specify an id

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/523/ for more details.

This revision is now accepted and ready to land.Wed, Nov 2, 1:22 PM
ardumont added inline comments.
swh/indexer/metadata_dictionary/codemeta.py
72
swh/indexer/metadata_dictionary/codemeta.py
72

oops, missed your comment