lgtm
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 26 2020
Jun 26 2020
douardda added inline comments to D3359: storage*: Open order parameter to origin-visit-get endpoint.
douardda committed rDJNLaff31e54e966: Use proper hash ids in tests' journal_data (authored by douardda).
Use proper hash ids in tests' journal_data
In D3353#82224, @vlorentz wrote:do you know where the old hashes came from?
Jun 25 2020
Jun 25 2020
closed by D3152
douardda committed rDMODe632abed41c5: Tag model entities with their "object_type" (authored by douardda).
Tag model entities with their "object_type"
Jun 24 2020
Jun 24 2020
update copyright
It's a bit sad we cannot generically use sets for this (because some model objects are still unhashable), so fine for me.
due to changes in from_disk, I'd rather have a new review on this.
improve commit message + use '_' in DiskBakedContent.object_type
Update the diff to make it work (see T2422)
Previously proposed "short-term" solution does not work. So the only "short-term" solution is to make DiskBakedContent inherit from BaseModel (or BaseContent).
This task is currently blocked by an implementation "detail":
douardda committed rDWAPPSe8f3588ede5f: Do not use the returned value of storage.origin_add in tests (authored by douardda).
Do not use the returned value of storage.origin_add in tests
rebase
Jun 23 2020
Jun 23 2020
douardda committed rDSTO621fc8d37795: Deprecate the origin_add_one() endpoint (authored by douardda).
Deprecate the origin_add_one() endpoint
douardda committed rDSTOfb603e1b9874: Make Storage.add_origin() return a sumary dict (authored by douardda).
Make Storage.add_origin() return a sumary dict
rebase
remove the previously added revision and fix the actual bug instead
rebase
add a revision to fix test_origin_visit_status_add_twice
Not sure about implications of the branches_count=1 argument, but it may be related to my other comment. Otherwise, LGTM.
Much easier to review! Thanks.
Jun 22 2020
Jun 22 2020
rebase
reword the commit message and fix cassandra impl
rebase
Fix for cassandra
Looks good to me but I would have preferred to see the "use assert_last_visit_matches" chuncks, which are a "pure" refactoring step, in a dedicated commit (so split this commit in 2 parts).
douardda committed rDSTO53c4392accec: Ensure ids are correct in tests' storage_data (authored by douardda).
Ensure ids are correct in tests' storage_data
Fix tests' storage_data revisions
douardda committed rDSTO19354bcd7e44: SQL: replace the hash(url) index by a unique btree(url) on the origin table (authored by douardda).
SQL: replace the hash(url) index by a unique btree(url) on the origin table
typo in commit msg
Jun 17 2020
Jun 17 2020
Fix/update the backfiller
prevent some timeout-kind-of stuff in test_backfiller
fix a couple of tests in test_backfill
In D3299#80579, @ardumont wrote:\m/
Thanks!
The description does not say it but you also dealt with origin-visit-status so another thanks!
douardda committed rDJNL6ea2d6e4c8ae: Set origin visits' metadata to None in journal_data (authored by douardda).
Set origin visits' metadata to None in journal_data
Jun 16 2020
Jun 16 2020
douardda committed rDSTOc2b673b49b88: Fix db_to_author() converter to return None is all fields are None (authored by douardda).
Fix db_to_author() converter to return None is all fields are None
douardda closed T2455: backfiller: properly support null authors as Resolved by committing rDSTOc2b673b49b88: Fix db_to_author() converter to return None is all fields are None.
douardda updated the diff for D3290: Fix db_to_author() converter to return None is all fields are None.
update the docstring and add type annotations
douardda committed rDMODb70b281404ff: Fix message generation in hypothesis strategy releases_d() (authored by douardda).
Fix message generation in hypothesis strategy releases_d()
douardda committed rDMODf723eb12af67: Fix the model: Revision.message can be None (authored by douardda).
Fix the model: Revision.message can be None
douardda committed rDMOD5c5f34fe7233: Use the optional() strategy instead of one_of(none(), ...) when possible (authored by douardda).
Use the optional() strategy instead of one_of(none(), ...) when possible
typo in a ci msg
Jun 15 2020
Jun 15 2020
not completely sure why this is necessary, but meh
douardda committed rDMODa427e184fb02: Allow negative_utc to be None in normalize_timestamp() (authored by douardda).
Allow negative_utc to be None in normalize_timestamp()
add a warning in the commit message
Jun 12 2020
Jun 12 2020
As discussed on IRC, a possible fix for is to clearly document the "limitations" of the current implementation.
douardda added inline comments to D3270: Introduce some scaffolding for an attrs-based BaseSchedulerModel.
douardda added inline comments to D3270: Introduce some scaffolding for an attrs-based BaseSchedulerModel.
douardda added inline comments to D3270: Introduce some scaffolding for an attrs-based BaseSchedulerModel.
In D3263#79681, @vlorentz wrote:This is needed to help consuming existing (invalid) messages from kafka.
If this is the only purpose, it should be in swh.storage.fixer
In D3263#79805, @olasd wrote:As I've pointed out on IRC, I think (offset, negative_utc) == (0, None) should raise an error, as this is undefined behavior.
Jun 11 2020
Jun 11 2020
douardda committed rDJNL07c629d64b07: Add hidden Content in tests' journal_data (authored by douardda).
Add hidden Content in tests' journal_data
douardda committed rDJNLed1fd693e81b: Remove now unused swh/journal/tests/utils.py (authored by douardda).
Remove now unused swh/journal/tests/utils.py
besides I don't like the _scheduler global var name, LGTM
Jun 10 2020
Jun 10 2020