Maybe add a line in the commit message about the behavior change of db_partition_indices() (returns an empty list instead of raising a ValueError)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 24 2019
Jun 24 2019
douardda added a comment to D1632: bitbucket: Allow incremental lister to start properly the first time.
LGTM but I'm biased
Jun 20 2019
Jun 20 2019
Jun 19 2019
Jun 19 2019
douardda committed rDJNL693b8f407fb4: cli: add a --concurrency cli option to content-replay (authored by douardda).
cli: add a --concurrency cli option to content-replay
douardda committed rDJNL022baee25827: replay: parallelize the copy of objects from a polled set (authored by douardda).
replay: parallelize the copy of objects from a polled set
douardda committed rDJNL253d150b5d0b: client: allow to specify any cfg parameter to KafkaConsumer() (authored by douardda).
client: allow to specify any cfg parameter to KafkaConsumer()
douardda committed rTPYARCd25ba395c37b: Add support for listing comments with diffs (authored by douardda).
Add support for listing comments with diffs
douardda committed rTPYARCc55da2739f90: diff: refactor the diff command and improve a bit the rendering (authored by douardda).
diff: refactor the diff command and improve a bit the rendering
Improve a bit JournalClient's docstring
Herald added a reviewer for D1608: client: allow to specify any cfg parameter to KafkaConsumer(): Reviewers.
Jun 18 2019
Jun 18 2019
"bon d'accord !"
Jun 14 2019
Jun 14 2019
douardda committed rDOBJS2b2ac1fc38c8: pathslicing: fix PathSlicingObjStorage.check() method (authored by douardda).
pathslicing: fix PathSlicingObjStorage.check() method
douardda committed rDOBJS869fe75ea5eb: tests/pathslicing: add a test for check() that ensure it does work (authored by douardda).
tests/pathslicing: add a test for check() that ensure it does work
douardda committed rDOBJSc8e349bf4a94: pathslicing: fix the 'not a gzip' error message in check() (authored by douardda).
pathslicing: fix the 'not a gzip' error message in check()
douardda committed rDOBJS605a0b5dfd9c: tests/pathslicing: improve tests for the check() method (authored by douardda).
tests/pathslicing: improve tests for the check() method
apply vlorentz' suggestions
Herald added a reviewer for D1587: pathslicing: fix PathSlicingObjStorage.check() method: Reviewers.
LGTM.
Now. what you do not understand "I don't understand why..." Is it "why the code does not behaves how it was intended to?" or "why the code was written so it actually uses a local storage?"
LGTM but please fix the abstract class's docstring as stated in the comment above.
Jun 13 2019
Jun 13 2019
douardda committed rDCORE9d6aed3056ba: cli/db: do not attempt to create the DB by default (authored by douardda).
cli/db: do not attempt to create the DB by default
update the docstring
cli: rename a admin cli commands
Jun 12 2019
Jun 12 2019
douardda committed rDJNL71ed469d5769: Bump dependency on swh.storage to v0.0.141 (authored by douardda).
Bump dependency on swh.storage to v0.0.141
douardda committed rDJNL88c544ea8aba: cli: do only listen to required kafka topic in content-replay command (authored by douardda).
cli: do only listen to required kafka topic in content-replay command
douardda committed rDJNLf86f3baf0903: cli: fix handling of get_journal_client's 'brokers' argument (authored by douardda).
cli: fix handling of get_journal_client's 'brokers' argument
douardda committed rDJNL433b85b4bc62: replay: do not crash if process_replay_objects_content() fails on one object (authored by douardda).
replay: do not crash if process_replay_objects_content() fails on one object
douardda committed rDJNL7ed426b34a20: JournalClient: change the prefix init argument dafault value to None (authored by douardda).
JournalClient: change the prefix init argument dafault value to None
I'm not very fond of testing several things at once. This does not "Test date parsing of origin_metadata_add" as such, it adds this testing as a side effect, in the middle of an unrelated test. Which is not a good idea. I mean, the test is named 'test_origin_metadata_get' and it does already too many things. Having the test named 'test_origin_metadata_get' fail because of bug in parsing dates in origin_metadata_add does not help the poor guy fixing these...
douardda accepted D1548: Add a test checking that directory_ls does not recurse into subdirs by default..
It's not that straightforward that this test does indeed do what the commit message pretends... A comment or 2 in the code of the test would not hurt. But meh
douardda accepted D1539: Add origin_visit counter to the in-mem storage + Add test for snapshot/release counters..
Ok, but I would have loved to see a word or 2 explaining why this revision is needed in the commit message.
douardda updated the diff for D1571: cli: fix brokers argument handling (+ a pile of small refactorings).
log an exception if process_replay_objects_content() fails
Herald added a reviewer for D1571: cli: fix brokers argument handling (+ a pile of small refactorings): Reviewers.
Jun 11 2019
Jun 11 2019
douardda committed rDSTOd8f0a7b0e5ef: storage: small typo in Storage.content_add_metadata's doc string (authored by douardda).
storage: small typo in Storage.content_add_metadata's doc string
douardda committed rDMOD0815880accd0: setup: register the 'identify' cli subcommand (authored by douardda).
setup: register the 'identify' cli subcommand
douardda committed rDMODd7ec4a61647a: cli: add support for --help on the 'identify' cli tool (authored by douardda).
cli: add support for --help on the 'identify' cli tool
douardda committed rDMOD60c3f7d4fb3d: cli: the 'objects' argument is in fact mandatory (authored by douardda).
cli: the 'objects' argument is in fact mandatory
rebase
Jun 7 2019
Jun 7 2019
douardda committed rDJNL2cb86247f815: replay: make unexpectedly received object_type log a warning (authored by douardda).
replay: make unexpectedly received object_type log a warning
douardda committed rDJNL46db4e82a19b: cli: extract the JournalClient instanciation in a dedicated function (authored by douardda).
cli: extract the JournalClient instanciation in a dedicated function
Add a content replayer service
douardda committed rDJNLbf0cf9d62dc7: backfill: use consistent 'prefix' config key instead of 'final_prefix' (authored by douardda).
backfill: use consistent 'prefix' config key instead of 'final_prefix'
cli: improve the CLI
douardda committed rDJNL74998fe39ae6: Ensure a default value for JournalClient's prefix parameter (authored by douardda).
Ensure a default value for JournalClient's prefix parameter
douardda committed rDJNLfc174641b95c: client: simplify a bit the JournalClient class (authored by douardda).
client: simplify a bit the JournalClient class
tests: refactor replayer tests
douardda committed rDJNLcf58471dac46: cli: register the 'journal' cli subcommand (authored by douardda).
cli: register the 'journal' cli subcommand
- Add a content replayer service
- cli: extract the JournalClient instanciation in a dedicated function
- replay: make unexpectedly received object_type log a warning
ok ok, I did split the kafka mock class in 2
add a TODO in test_cli about content-replay
replay: log warnings in case of unexpected object types
In D1541#34664, @vlorentz wrote:Also, your new CLI needs tests :)
fix an error (brokers can be a tuple) making test_cli fails
Jun 6 2019
Jun 6 2019
The diffs looks fine, but I'd like to have confirmation the code works properly in real conditions (in a docker session) before we merge this.
fix commit msg
should address vlortenz's comments
Several refactorings and git history cleanups
Jun 5 2019
Jun 5 2019
this is now part of D1540
rebase + fix typo