Keep the (tuple) parenthesis
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 25 2020
Sep 25 2020
ardumont updated the diff for D4049: test: Update missing scenario on update metadata with multipart (post).
ardumont added inline comments to D4049: test: Update missing scenario on update metadata with multipart (post).
swh-public-ci added a comment to D4052: Fix transition deposit to deposited state with empty post on SE IRI.
Build is green
ardumont retitled D4052: Fix transition deposit to deposited state with empty post on SE IRI from Fix transition deposit to deposited state with empty post to Fix transition deposit to deposited state with empty post on SE IRI.
ardumont updated the diff for D4052: Fix transition deposit to deposited state with empty post on SE IRI.
Rework commit message
olasd removed reviewers for D4017: Improve code quality and doc in BufferedProxyStorage: Reviewers, olasd.
swh-public-ci added a comment to D4052: Fix transition deposit to deposited state with empty post on SE IRI.
Build is green
ardumont retitled D4052: Fix transition deposit to deposited state with empty post on SE IRI from Add and fix missing scenarios around transitioning deposit to deposited to Fix transition deposit to deposited state with empty post.
@olasd All the points we have checked yesterday should be addressed.
ardumont added inline comments to D4052: Fix transition deposit to deposited state with empty post on SE IRI.
ardumont updated the diff for D4052: Fix transition deposit to deposited state with empty post on SE IRI.
Simplify the check, IN-PROGRESS if not specified, is False so no need for the elif condition
douardda committed rDMODbe8f1a559d82: Adapt cli declaration entrypoint to swh.core 0.3 (authored by douardda).
Adapt cli declaration entrypoint to swh.core 0.3
Build is green
and with the pytest.ini hunk we don't need a (non working) dependency on swh.core[testing]
ardumont retitled D4013: Allow deposit metadata update on deposit already complete from wip: Allow deposit metadata update on deposit already complete to Allow deposit metadata update on deposit already complete.
ardumont retitled D4048: test: Update missing scenario on update metadata with multipart (put) from test: Update missing scenario on update metadata with multipart (post) to test: Update missing scenario on update metadata with multipart (put).
isolate the reverse_proxy configuration in a dedicated profile
Build is green
- moving it to the command/group docstring would resolve the problem, but causes unexpectedly the docstring to be ignored by click (we wants static strings here)
add a precision in the ci message for the pytest.ini hunk
anlambert committed rDWAPPS3e8584e9f805: SWHIDs: Do not add path qualifier for a root directory (authored by anlambert).
SWHIDs: Do not add path qualifier for a root directory
Harbormaster failed remote builds in B15569: Diff 14278 for D4052: Fix transition deposit to deposited state with empty post on SE IRI!
swh-public-ci added a comment to D4052: Fix transition deposit to deposited state with empty post on SE IRI.
Build has FAILED
ardumont updated the summary of D4052: Fix transition deposit to deposited state with empty post on SE IRI.
Build is green
Build is green
Update: Address @ardumont comment
vlorentz added inline comments to D4049: test: Update missing scenario on update metadata with multipart (post).
one remark but otherwise, looks good.
ardumont committed rSPSITE91fa7e4ba7e3: deposit: Explicit missing extraction_dir configuration (authored by ardumont).
deposit: Explicit missing extraction_dir configuration
Build is green
IMO it's more readable like this
ardumont added inline comments to D4049: test: Update missing scenario on update metadata with multipart (post).
ardumont retitled D4047: Add functional metadata checks prior to actually update metadata from Check new metadata pass the functional checks prior to update them to Add functional metadata checks prior to actually update metadata.
Also, I added description of defaults in the command help, but it reads badly, do you know a better way?
Remarks:
- clicks inline even if I use a docstring
- moving it to the command/group docstring would resolve the problem, but causes unexpectedly the docstring to be ignored by click (we wants static strings here)
swh-public-ci added a comment to D4049: test: Update missing scenario on update metadata with multipart (post).
Build is green
ardumont updated the summary of D4049: test: Update missing scenario on update metadata with multipart (post).
oh, ok
swh-public-ci added a comment to D4048: test: Update missing scenario on update metadata with multipart (put).
Build is green
ardumont updated the summary of D4049: test: Update missing scenario on update metadata with multipart (post).
Build is green
ardumont retitled D4048: test: Update missing scenario on update metadata with multipart (put) from test_deposit_update: Add missing scenario on multipart update to test: Update missing scenario on update metadata with multipart (post).
ardumont updated the diff for D4048: test: Update missing scenario on update metadata with multipart (put).
- Rework commit message
- drop spurious #noqa near the tests change so the coverage shows <- ikr ¯\_(ツ)_/¯
extracted isort change from commit, which was directly merged by olasd
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
Run isort after the CLI import changes
swh-public-ci added a comment to D4048: test: Update missing scenario on update metadata with multipart (put).
Build is green
olasd committed rDTSCNa7a17e7ed6a4: Pin black in tox to the same version as pre-commit (authored by olasd).
Pin black in tox to the same version as pre-commit
olasd committed rDTSCN38a8e7f14e48: Run isort on the changes of f10d3d87cbcb0cb80e6ebfd1c3ea699bb11040f5 (authored by olasd).
Run isort on the changes of f10d3d87cbcb0cb80e6ebfd1c3ea699bb11040f5
swh-public-ci added a comment to D4047: Add functional metadata checks prior to actually update metadata.
Build is green
ardumont updated the diff for D4047: Add functional metadata checks prior to actually update metadata.
Fix bad docstring (copy/paste ¯\_(ツ)_/¯)
ardumont added inline comments to D4047: Add functional metadata checks prior to actually update metadata.
In D4046#100086, @vlorentz wrote:fail if file does not exist instead of using empty config dict
Isn't it already the default behavior?
moranegg added inline comments to D4047: Add functional metadata checks prior to actually update metadata.
runtime: Add functional checks on metadata received (same checks as what the checker does for the standard deposit scenario)
ardumont added inline comments to D4047: Add functional metadata checks prior to actually update metadata.
swh-public-ci added a comment to D4047: Add functional metadata checks prior to actually update metadata.
Build is green
ardumont updated the summary of D4047: Add functional metadata checks prior to actually update metadata.
As @olasd pointed out, async is a keyword so let's not use it as module name :-)
GitHub <noreply@github.com> committed rSPMY937d0443c6da: Merge pull request #1315 from elmobp/master (authored by daianamezdrea <46529728+daianamezdrea@users.noreply.github.com>).
Merge pull request #1315 from elmobp/master
fe80 <steffyfort@gmail.com> committed rSPMY62e9e36f3578: add package provider and source (authored by fe80 <steffyfort@gmail.com>).
add package provider and source
GitHub <noreply@github.com> committed rSPMY16b1c8c46b04: Merge pull request #1312 from tomkrouper/modules-10723 (authored by sheenaajay <sheena@puppet.com>).
Merge pull request #1312 from tomkrouper/modules-10723
Michael Baker <michael.baker@bulletproof.net> committed rSPMY5a45f024779b: Remove non pritinable characters (authored by Michael Baker <michael.baker@bulletproof.net>).
Remove non pritinable characters
GitHub <noreply@github.com> committed rSPMY802a2913b90b: Merge pull request #1314 from fe80/feature/package_provider (authored by daianamezdrea <46529728+daianamezdrea@users.noreply.github.com>).
Merge pull request #1314 from fe80/feature/package_provider