Differential D4051

Adapt cli declaration entrypoint to swh.core 0.3
ClosedPublic
Actions

Authored by douardda on Sep 25 2020, 3:15 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODbe8f1a559d82: Adapt cli declaration entrypoint to swh.core 0.3

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 25 2020, 3:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 25 2020, 3:15 PM

Harbormaster completed remote builds in B15568: Diff 14277.Sep 25 2020, 3:17 PM

Build is green

Patch application report for D4051 (id=14277)

Rebasing onto e0b4b9464a...

Current branch diff-target is up to date.

Changes applied before test

commit cb5348ac332c2cbb3cb7a0ee8c8d10e4527d0ef7
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Sep 23 17:52:14 2020 +0200

    Adapt cli declaration entrypoint to swh.core 0.3

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/137/ for more details.

ardumont accepted this revision.Sep 25 2020, 3:19 PM

This revision is now accepted and ready to land.Sep 25 2020, 3:19 PM

add a precision in the ci message for the pytest.ini hunk

ardumont added inline comments.Sep 25 2020, 3:23 PM

pytest.ini
2	heh right, stop "autoload that "thing" or something ;)

ardumont accepted this revision.Sep 25 2020, 3:23 PM

Build is green

Patch application report for D4051 (id=14280)

Rebasing onto e0b4b9464a...

Current branch diff-target is up to date.

Changes applied before test

commit bfbd72a468c24e66dca3f18159e03dfa8924b73c
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Sep 23 17:52:14 2020 +0200

    Adapt cli declaration entrypoint to swh.core 0.3
    
    The addition of '-p no:pytest_swh_core' in pytest.ini is needed to
    prevent pytest from loading the pytest_swh_core plugin which we do not
    need here and which would require some more dependencies (e.g.
    requests).

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/138/ for more details.

Harbormaster completed remote builds in B15571: Diff 14280.Sep 25 2020, 3:24 PM

and with the pytest.ini hunk we don't need a (non working) dependency on swh.core[testing]

Build is green

Patch application report for D4051 (id=14282)

Rebasing onto e0b4b9464a...

Current branch diff-target is up to date.

Changes applied before test

commit be8f1a559d8209710a08ca48d93b7f513fa1c42f
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Sep 23 17:52:14 2020 +0200

    Adapt cli declaration entrypoint to swh.core 0.3
    
    The addition of '-p no:pytest_swh_core' in pytest.ini is needed to
    prevent pytest from loading the pytest_swh_core plugin which we do not
    need here and which would require some more dependencies (e.g.
    requests).

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/139/ for more details.

Harbormaster completed remote builds in B15573: Diff 14282.Sep 25 2020, 3:26 PM

Closed by commit rDMODbe8f1a559d82: Adapt cli declaration entrypoint to swh.core 0.3 (authored by douardda). · Explain WhySep 25 2020, 3:27 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDMODbe8f1a559d82: Adapt cli declaration entrypoint to swh.core 0.3.

ardumont mentioned this in D4182: conftest: Declare swh.core pytest_plugin.Oct 7 2020, 3:47 PM

vlorentz mentioned this in D5460: Remove accidental dependency of 'swh-identify' on swh-core.Apr 8 2021, 4:13 PM