Page MenuHomeSoftware Heritage

SWHIDs: Do not add path qualifier for a root directory
ClosedPublic

Authored by anlambert on Sep 25 2020, 2:43 PM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4050 (id=14275)

Rebasing onto 7ac279dfd0...

Current branch diff-target is up to date.
Changes applied before test
commit 2c60bd05fe126e0d02d6a5220eb5d5209c00d9a4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Sep 25 14:41:48 2020 +0200

    SWHIDs: Do not add path qualifier for a root directory
    
    Related to T2636

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/391/ for more details.

ardumont added a subscriber: ardumont.

one remark but otherwise, looks good.

thanks

swh/web/tests/browse/views/test_content.py
527

maybe keep at least one somewhere to demonstrate that it's flipped to None if that occurs?

This revision is now accepted and ready to land.Sep 25 2020, 3:00 PM
swh/web/tests/browse/views/test_content.py
527

Yes, good idea ! I will add the check in test_get_swhids_info_directory_context.

Build is green

Patch application report for D4050 (id=14276)

Rebasing onto 7ac279dfd0...

Current branch diff-target is up to date.
Changes applied before test
commit 3e8584e9f80568e386141b452988e87cd5062d55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Sep 25 14:41:48 2020 +0200

    SWHIDs: Do not add path qualifier for a root directory
    
    Related to T2636

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/392/ for more details.