User Details
User Details
- User Since
- Sep 2 2020, 11:39 AM (11 w, 6 d)
Yesterday
Yesterday
tenma updated the title for P878 Config library WIP (does not run for now) from Config library WIP to Config library WIP (does not run for now).
Tue, Nov 3
Tue, Nov 3
tenma updated the task description for T2743: Investigate why logging is inconsistent.
tenma updated the task description for T2743: Investigate why logging is inconsistent.
tenma updated the task description for T2743: Investigate why logging is inconsistent.
Fri, Oct 30
Fri, Oct 30
tenma updated the task description for T2743: Investigate why logging is inconsistent.
tenma updated the task description for T2743: Investigate why logging is inconsistent.
Thu, Oct 29
Thu, Oct 29
tenma committed rDCORE12fa6f263d48: core tests: disambiguate arg 'request' through typing (authored by tenma).
core tests: disambiguate arg 'request' through typing
tenma updated the diff for D4382: core tests: disambiguate arg 'request' through typing.
Rebase
tenma retitled D4382: core tests: disambiguate arg 'request' through typing from tests: disambiguate arg 'request' through typing to core tests: disambiguate arg 'request' through typing.
tenma updated the diff for D4382: core tests: disambiguate arg 'request' through typing.
Removed comment
Wed, Oct 28
Wed, Oct 28
tenma moved T1191: Vault: reschedule failed tasks after a manual/non-manual resolution from Backlog to In progress on the Vault board.
tenma moved T1191: Vault: reschedule failed tasks after a manual/non-manual resolution from In progress to Backlog on the Vault board.
tenma committed rDVAUcf6aa9558f02: Refactor vault configuration without the args indirection (authored by tenma).
Refactor vault configuration without the args indirection
tenma updated the diff for D4330: Allow vault configuration without the args indirection.
Reset author
Tue, Oct 27
Tue, Oct 27
tenma updated the summary of D4330: Allow vault configuration without the args indirection.
Pushed but did not trigger close.
tenma updated the diff for D4352: Remove unused fixture argument 'request'.
Repush
tenma updated the diff for D4330: Allow vault configuration without the args indirection.
Refactored configuration checking in vault server+worker
Remove unused fixture argument 'request'
Mon, Oct 26
Mon, Oct 26
Oct 23 2020
Oct 23 2020
tenma added inline comments to D4330: Allow vault configuration without the args indirection.
tenma committed rDVAU448dfa07cda7: Replace file modes literals to DentryPerms enum (authored by tenma).
Replace file modes literals to DentryPerms enum
Oct 22 2020
Oct 22 2020
LGTM, but could be splitted
tenma updated the summary of D4329: vault.server: Introduce typed VaultInterface.
Oct 16 2020
Oct 16 2020
tenma added inline comments to D4284: scheduler: Type and unify get_scheduler factory with other factories.
tenma moved T1964: Timeout reached while assembling the requested bundle (Rocrail) from Backlog to Done on the Vault board.
tenma moved T2284: Fix- download button shows no popup when cooking had failed from Backlog to Done on the Vault board.
tenma moved T2388: Can't create cooking requests in swh-web from Backlog to Done on the Vault board.
tenma moved T1191: Vault: reschedule failed tasks after a manual/non-manual resolution from Backlog to In progress on the Vault board.
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
Oct 15 2020
Oct 15 2020
tenma added inline comments to D2958: client: support optional date in Revision and Release.
tenma requested changes to D2958: client: support optional date in Revision and Release.
tenma added inline comments to D2958: client: support optional date in Revision and Release.
tenma added inline comments to D2958: client: support optional date in Revision and Release.
Oct 14 2020
Oct 14 2020
tenma retitled D4089: Add tests and fix behavior of scanner cli from WIP Add tests and fix behavior of scanner cli to Add tests and fix behavior of scanner cli.
Oct 13 2020
Oct 13 2020
tenma committed rDTSCN92f684b71e7d: cli: fix behavior in case an invalid config file is given (authored by tenma).
cli: fix behavior in case an invalid config file is given
cli: add tests
tenma committed rDTSCN65c236aadce3: Fix not self-contained temp_path fixture in conftest (authored by tenma).
Fix not self-contained temp_path fixture in conftest
tenma committed rDTSCN56fdacbc970f: Import qualified scanner.scan inside cli.scan entrypoint (authored by tenma).
Import qualified scanner.scan inside cli.scan entrypoint
tenma updated the diff for D4089: Add tests and fix behavior of scanner cli.
Simplified assertions
Oct 11 2020
Oct 11 2020
tenma updated the diff for D4089: Add tests and fix behavior of scanner cli.
- Import qualified scanner.scan inside cli.scan entrypoint
- Fix not self-contained temp_path fixture in conftest
- cli: fix behavior in case an invalid config file is given
- cli: add tests
Oct 8 2020
Oct 8 2020
PEP8 renaming of scanner modules
tenma committed rDTSCNbb5ccd812a84: model: fix Tree.toDict to be side-effect free (authored by tenma).
model: fix Tree.toDict to be side-effect free
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Rebase
tenma added inline comments to D4198: PEP8 refactoring of scanner modules.
tenma edited reviewers for D4186: scanner.model: Fix Tree.toDict to be side-effect free, added: douardda; removed: Reviewers.
tenma updated the summary of D4186: scanner.model: Fix Tree.toDict to be side-effect free.
tenma retitled D4186: scanner.model: Fix Tree.toDict to be side-effect free from Fix Tree.toDict updating a default arg dict to scanner.model: Fix Tree.toDict to be side-effect free.
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Reworded again
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Better with the new commit ID
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Improved commit message
Oct 7 2020
Oct 7 2020
Oct 6 2020
Oct 6 2020
tenma added a comment to D4089: Add tests and fix behavior of scanner cli.
@zack it is not ready yet, need iteration with douardda.
Thanks for the remark on the token, should not be here.
tenma added inline comments to D4089: Add tests and fix behavior of scanner cli.
Oct 5 2020
Oct 5 2020
Improve cli documentation
tenma added a comment to D4145: java: refactor AllowedEdges to remove its Graph attribute.
Just walking by...
Maybe remove also the following import in Graph:
import it.unimi.dsi.big.webgraph.BVGraph;
tenma committed rDTSCN15875836f096: Remove parse_url helper and inline trailing slash fix (authored by tenma).
Remove parse_url helper and inline trailing slash fix
tenma updated the diff for D4130: Improve cli documentation.
Finally found how to keep (paragraph) formatting with Click: "\n\n\b\n"
Oct 2 2020
Oct 2 2020
tenma updated the summary of D4130: Improve cli documentation.
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
tenma updated the diff for D4089: Add tests and fix behavior of scanner cli.
Rebased to remove doc and parse_url commits
tenma updated the diff for D4130: Improve cli documentation.
Fixed the cherry-picked commit
tenma added inline comments to D4130: Improve cli documentation.
tenma updated the diff for D4131: Remove parse_url helper that adds no real value.
Inlined the intersting fix
tenma added a comment to D4131: Remove parse_url helper that adds no real value.
I would add that I have even been bitten by it, providing a "http://" url that became "https://"http://""... :)
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
tenma added inline comments to D4130: Improve cli documentation.
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
tenma added a comment to D4090: Improve cli documentation.
Hm I submitted 2 times this commit, but the last one is D4130.
Sorry I will close this. Config related code will go to core.config, yes, when it will be ready for it.
tenma added a comment to D4131: Remove parse_url helper that adds no real value.
OTOH it is CLI so interactive use so the error is instant.
The function also had a bad name.
I can just keep adding the trailing slash if you prefer, inline (no specific function).