User Details
- User Since
- Sep 2 2020, 11:39 AM (25 w, 1 d)
Fri, Feb 12
Thu, Feb 11
Rebase
Wed, Feb 10
Minor phrasing fixes
Tue, Feb 9
Update based on @vlorentz remarks
Small docstring fix
Change title, it is more a guide than a tutorial IMO
Add the doc to the documentation index
Adressed other remarks from @moranegg
Fri, Feb 5
Adressed parts of the remarks from @moranegg
Address remarks.
Improve URL formatting.
Improved the Sentry debugging section
Wed, Feb 3
- move known_ids to an instance attribute
- split file processing loop into processing new files
then all files
- lru cache to avoid duplicate requests
- typing
- logging and asserting
- notifying progress to vault backend
Mon, Feb 1
Jan 26 2021
Rename "singleton" to "record"
Reword commit
Add implementation instructions to the template
In any case, bravo for the effort on this tough lister!
Jan 25 2021
improve handling of credentials
Jan 22 2021
Jan 21 2021
Jan 20 2021
Remove "WIP" from the commit message
Remove the lister model
Jan 19 2021
Clean code and fix page type
Revert changes to the credentials setting method, and improve corresponding test
Remove tenacity wait parameter
Remove the persistent isort conftest modification from diff
Jan 18 2021
Have test coverage for credentials setting
- fix assert
- fix typing
- add a warning on credentials
Jan 17 2021
- remove useless code as per feeback
- improve tests
Jan 15 2021
In short, let's KISS!
It would be great to parametrize the request and error type, but unfortunately it does not seem easy to do...
incremental review
did not see the requested change on clustering keys by vlorentz
TGTM, but needs a look by someone more knowledgeable about the DBs