Page MenuHomeSoftware Heritage

tenma (Tenma)
User

Projects

User Details

User Since
Sep 2 2020, 11:39 AM (11 w, 6 d)

Recent Activity

Yesterday

tenma updated the title for P878 Config library WIP (does not run for now) from Config library WIP to Config library WIP (does not run for now).
Tue, Nov 24, 2:54 PM · Core & foundations
tenma created P878 Config library WIP (does not run for now).
Tue, Nov 24, 2:50 PM · Core & foundations

Tue, Nov 3

tenma updated the task description for T2743: Investigate why logging is inconsistent.
Tue, Nov 3, 10:45 AM · Vault, Object storage, Core & foundations
tenma updated the task description for T2743: Investigate why logging is inconsistent.
Tue, Nov 3, 10:30 AM · Vault, Object storage, Core & foundations
tenma updated the task description for T2743: Investigate why logging is inconsistent.
Tue, Nov 3, 10:23 AM · Vault, Object storage, Core & foundations

Fri, Oct 30

tenma updated the task description for T2743: Investigate why logging is inconsistent.
Fri, Oct 30, 2:47 PM · Vault, Object storage, Core & foundations
tenma updated the task description for T2743: Investigate why logging is inconsistent.
Fri, Oct 30, 2:46 PM · Vault, Object storage, Core & foundations

Thu, Oct 29

tenma triaged T2743: Investigate why logging is inconsistent as Normal priority.
Thu, Oct 29, 6:19 PM · Vault, Object storage, Core & foundations
tenma committed rDCORE12fa6f263d48: core tests: disambiguate arg 'request' through typing (authored by tenma).
core tests: disambiguate arg 'request' through typing
Thu, Oct 29, 4:41 PM
tenma closed D4382: core tests: disambiguate arg 'request' through typing.
Thu, Oct 29, 4:41 PM
tenma updated the diff for D4382: core tests: disambiguate arg 'request' through typing.

Rebase

Thu, Oct 29, 4:39 PM
tenma retitled D4382: core tests: disambiguate arg 'request' through typing from tests: disambiguate arg 'request' through typing to core tests: disambiguate arg 'request' through typing.
Thu, Oct 29, 4:36 PM
tenma updated the diff for D4382: core tests: disambiguate arg 'request' through typing.

Removed comment

Thu, Oct 29, 4:35 PM
tenma created D4382: core tests: disambiguate arg 'request' through typing.
Thu, Oct 29, 3:15 PM

Wed, Oct 28

tenma moved T1191: Vault: reschedule failed tasks after a manual/non-manual resolution from Backlog to In progress on the Vault board.
Wed, Oct 28, 6:47 PM · Vault
tenma moved T1191: Vault: reschedule failed tasks after a manual/non-manual resolution from In progress to Backlog on the Vault board.
Wed, Oct 28, 6:46 PM · Vault
tenma committed rDVAUcf6aa9558f02: Refactor vault configuration without the args indirection (authored by tenma).
Refactor vault configuration without the args indirection
Wed, Oct 28, 10:11 AM
tenma closed D4330: Allow vault configuration without the args indirection.
Wed, Oct 28, 10:11 AM
tenma updated the diff for D4330: Allow vault configuration without the args indirection.

Reset author

Wed, Oct 28, 10:03 AM

Tue, Oct 27

tenma updated the summary of D4330: Allow vault configuration without the args indirection.
Tue, Oct 27, 5:36 PM
tenma closed D4352: Remove unused fixture argument 'request'.

Pushed but did not trigger close.

Tue, Oct 27, 5:35 PM
tenma updated the diff for D4352: Remove unused fixture argument 'request'.

Repush

Tue, Oct 27, 4:34 PM
tenma updated the diff for D4330: Allow vault configuration without the args indirection.

Refactored configuration checking in vault server+worker

Tue, Oct 27, 4:24 PM
tenma commandeered D4330: Allow vault configuration without the args indirection.
Tue, Oct 27, 2:27 PM
tenma committed rDVAU35438cadcd91: Remove unused fixture argument 'request' (authored by tenma).
Remove unused fixture argument 'request'
Tue, Oct 27, 2:13 PM

Mon, Oct 26

tenma edited P837 ingesting_cpython_connreset.
Mon, Oct 26, 4:30 PM
tenma edited P837 ingesting_cpython_connreset.
Mon, Oct 26, 4:28 PM

Oct 23 2020

tenma added inline comments to D4330: Allow vault configuration without the args indirection.
Oct 23 2020, 7:04 PM
tenma created D4352: Remove unused fixture argument 'request'.
Oct 23 2020, 6:55 PM
tenma committed rDVAU448dfa07cda7: Replace file modes literals to DentryPerms enum (authored by tenma).
Replace file modes literals to DentryPerms enum
Oct 23 2020, 6:26 PM
tenma closed D4350: Replace file modes literals to DentryPerms enum.
Oct 23 2020, 6:26 PM
tenma created D4350: Replace file modes literals to DentryPerms enum.
Oct 23 2020, 5:45 PM

Oct 22 2020

tenma accepted D4331: requirements-test: Add missing asynctest dependency.
Oct 22 2020, 6:23 PM
tenma accepted D4329: vault.server: Introduce typed VaultInterface.

LGTM, but could be splitted

Oct 22 2020, 6:15 PM
tenma updated the summary of D4329: vault.server: Introduce typed VaultInterface.
Oct 22 2020, 5:05 PM

Oct 16 2020

tenma accepted D4284: scheduler: Type and unify get_scheduler factory with other factories.
Oct 16 2020, 6:35 PM
tenma added inline comments to D4284: scheduler: Type and unify get_scheduler factory with other factories.
Oct 16 2020, 6:11 PM
tenma edited P826 doco_logs_up_nodb.
Oct 16 2020, 3:19 PM
tenma moved T1964: Timeout reached while assembling the requested bundle (Rocrail) from Backlog to Done on the Vault board.
Oct 16 2020, 11:33 AM · Vault
tenma moved T2284: Fix- download button shows no popup when cooking had failed from Backlog to Done on the Vault board.
Oct 16 2020, 11:33 AM · Web app, Vault
tenma moved T2388: Can't create cooking requests in swh-web from Backlog to Done on the Vault board.
Oct 16 2020, 11:33 AM · Vault, Web app
tenma moved T1191: Vault: reschedule failed tasks after a manual/non-manual resolution from Backlog to In progress on the Vault board.
Oct 16 2020, 11:32 AM · Vault
tenma claimed T1191: Vault: reschedule failed tasks after a manual/non-manual resolution.
Oct 16 2020, 11:31 AM · Vault
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
Oct 16 2020, 10:13 AM · Core & foundations
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
Oct 16 2020, 10:12 AM · Core & foundations

Oct 15 2020

tenma accepted D2958: client: support optional date in Revision and Release.
Oct 15 2020, 11:43 AM
tenma added inline comments to D2958: client: support optional date in Revision and Release.
Oct 15 2020, 11:10 AM
tenma requested changes to D2958: client: support optional date in Revision and Release.
Oct 15 2020, 10:59 AM
tenma added inline comments to D2958: client: support optional date in Revision and Release.
Oct 15 2020, 10:54 AM
tenma added inline comments to D2958: client: support optional date in Revision and Release.
Oct 15 2020, 10:49 AM

Oct 14 2020

tenma closed D4089: Add tests and fix behavior of scanner cli.
Oct 14 2020, 11:47 AM
tenma retitled D4089: Add tests and fix behavior of scanner cli from WIP Add tests and fix behavior of scanner cli to Add tests and fix behavior of scanner cli.
Oct 14 2020, 11:47 AM

Oct 13 2020

tenma committed rDTSCN92f684b71e7d: cli: fix behavior in case an invalid config file is given (authored by tenma).
cli: fix behavior in case an invalid config file is given
Oct 13 2020, 3:24 PM
tenma committed rDTSCNc189dec377b7: cli: add tests (authored by tenma).
cli: add tests
Oct 13 2020, 3:24 PM
tenma committed rDTSCN65c236aadce3: Fix not self-contained temp_path fixture in conftest (authored by tenma).
Fix not self-contained temp_path fixture in conftest
Oct 13 2020, 3:24 PM
tenma committed rDTSCN56fdacbc970f: Import qualified scanner.scan inside cli.scan entrypoint (authored by tenma).
Import qualified scanner.scan inside cli.scan entrypoint
Oct 13 2020, 3:24 PM
tenma updated the diff for D4089: Add tests and fix behavior of scanner cli.

Simplified assertions

Oct 13 2020, 3:19 PM

Oct 11 2020

tenma updated the diff for D4089: Add tests and fix behavior of scanner cli.
  • Import qualified scanner.scan inside cli.scan entrypoint
  • Fix not self-contained temp_path fixture in conftest
  • cli: fix behavior in case an invalid config file is given
  • cli: add tests
Oct 11 2020, 11:28 AM

Oct 8 2020

tenma committed rDTSCN88ded8631be9: PEP8 renaming of scanner modules (authored by tenma).
PEP8 renaming of scanner modules
Oct 8 2020, 6:46 PM
tenma closed D4198: PEP8 refactoring of scanner modules.
Oct 8 2020, 6:46 PM
tenma committed rDTSCNbb5ccd812a84: model: fix Tree.toDict to be side-effect free (authored by tenma).
model: fix Tree.toDict to be side-effect free
Oct 8 2020, 6:46 PM
tenma closed D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Oct 8 2020, 6:46 PM
tenma updated the diff for D4198: PEP8 refactoring of scanner modules.

Rebase

Oct 8 2020, 6:40 PM
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.

Rebase

Oct 8 2020, 6:39 PM
tenma added inline comments to D4198: PEP8 refactoring of scanner modules.
Oct 8 2020, 6:17 PM
tenma created D4198: PEP8 refactoring of scanner modules.
Oct 8 2020, 12:12 PM
tenma edited reviewers for D4186: scanner.model: Fix Tree.toDict to be side-effect free, added: douardda; removed: Reviewers.
Oct 8 2020, 11:36 AM
tenma updated the summary of D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Oct 8 2020, 11:33 AM
tenma retitled D4186: scanner.model: Fix Tree.toDict to be side-effect free from Fix Tree.toDict updating a default arg dict to scanner.model: Fix Tree.toDict to be side-effect free.
Oct 8 2020, 11:33 AM
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.

Reworded again

Oct 8 2020, 11:25 AM
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.

Better with the new commit ID

Oct 8 2020, 11:17 AM
tenma updated the diff for D4186: scanner.model: Fix Tree.toDict to be side-effect free.

Improved commit message

Oct 8 2020, 11:09 AM

Oct 7 2020

tenma created D4186: scanner.model: Fix Tree.toDict to be side-effect free.
Oct 7 2020, 5:16 PM

Oct 6 2020

tenma added a comment to D4089: Add tests and fix behavior of scanner cli.

@zack it is not ready yet, need iteration with douardda.
Thanks for the remark on the token, should not be here.

Oct 6 2020, 10:57 AM
tenma added inline comments to D4089: Add tests and fix behavior of scanner cli.
Oct 6 2020, 10:56 AM

Oct 5 2020

tenma committed rDTSCNccf123a4cefd: Improve cli documentation (authored by tenma).
Improve cli documentation
Oct 5 2020, 6:19 PM
tenma closed D4130: Improve cli documentation.
Oct 5 2020, 6:19 PM
tenma added a comment to D4145: java: refactor AllowedEdges to remove its Graph attribute.

Just walking by...
Maybe remove also the following import in Graph:
import it.unimi.dsi.big.webgraph.BVGraph;

Oct 5 2020, 6:11 PM
tenma updated the diff for D4130: Improve cli documentation.

Rebased with master

Oct 5 2020, 5:53 PM
tenma committed rDTSCN15875836f096: Remove parse_url helper and inline trailing slash fix (authored by tenma).
Remove parse_url helper and inline trailing slash fix
Oct 5 2020, 3:51 PM
tenma closed D4131: Remove parse_url helper that adds no real value.
Oct 5 2020, 3:51 PM
tenma updated the diff for D4130: Improve cli documentation.

Finally found how to keep (paragraph) formatting with Click: "\n\n\b\n"

Oct 5 2020, 3:37 PM

Oct 2 2020

tenma updated the summary of D4130: Improve cli documentation.
Oct 2 2020, 7:02 PM
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
Oct 2 2020, 7:02 PM
tenma updated the diff for D4089: Add tests and fix behavior of scanner cli.

Rebased to remove doc and parse_url commits

Oct 2 2020, 6:59 PM
tenma updated the diff for D4130: Improve cli documentation.

Fixed the cherry-picked commit

Oct 2 2020, 6:51 PM
tenma updated the diff for D4130: Improve cli documentation.

Re-submit

Oct 2 2020, 5:59 PM
tenma added inline comments to D4130: Improve cli documentation.
Oct 2 2020, 5:56 PM
tenma updated the diff for D4131: Remove parse_url helper that adds no real value.

Inlined the intersting fix

Oct 2 2020, 5:41 PM
tenma added a comment to D4131: Remove parse_url helper that adds no real value.

I would add that I have even been bitten by it, providing a "http://" url that became "https://"http://""... :)

Oct 2 2020, 5:28 PM
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
Oct 2 2020, 4:18 PM · Core & foundations
tenma added inline comments to D4130: Improve cli documentation.
Oct 2 2020, 4:12 PM
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
Oct 2 2020, 4:00 PM
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
Oct 2 2020, 3:56 PM
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
Oct 2 2020, 3:48 PM · Core & foundations
tenma updated the task description for T1410: Kill implicit configuration: new configuration scheme.
Oct 2 2020, 3:35 PM · Core & foundations
tenma updated the summary of D4089: Add tests and fix behavior of scanner cli.
Oct 2 2020, 3:33 PM
tenma abandoned D4090: Improve cli documentation.
Oct 2 2020, 3:27 PM
tenma added a comment to D4090: Improve cli documentation.

Hm I submitted 2 times this commit, but the last one is D4130.
Sorry I will close this. Config related code will go to core.config, yes, when it will be ready for it.

Oct 2 2020, 3:27 PM
tenma added a comment to D4131: Remove parse_url helper that adds no real value.

OTOH it is CLI so interactive use so the error is instant.
The function also had a bad name.
I can just keep adding the trailing slash if you prefer, inline (no specific function).

Oct 2 2020, 3:23 PM