- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 4 2022
Looks good to me, better fixing issues that might araise when testing the lister in new diffs.
Looks good to me, makes me think that I should deduplicate the tests for the tasks created from ListedOrigins in loaders through a fixture and add missing ones, I will push a diff for that.
Oct 3 2022
Use warning log level instead of info.
I recalled it is also important to test the loader parameters when created from ListedOrigin instances so I have added this test below:
diff --git a/swh/loader/core/tests/test_tasks.py b/swh/loader/core/tests/test_tasks.py index bf8d2e1..c0ab361 100644 --- a/swh/loader/core/tests/test_tasks.py +++ b/swh/loader/core/tests/test_tasks.py @@ -3,8 +3,13 @@ # License: GNU General Public License version 3, or any later version # See top-level LICENSE file for more information
rebase
Rebase
Looks good to me !
Sep 30 2022
LGTM, just a couple of nitpicks to handle and I will accept it.
LGTM, two small comments to handle before I can accept it.
@franckbret , you updated the wrong diff (conda instead of hackage)
Improve tests
Address @vlorentz comments.
Sep 29 2022
Here the problems is that the cabal file isn't formatted as the naïve parser expect.. we expect each line to be something like {k}: {v}\n but in this case its {k}: \n \t {v} \n and we end with an empty value..
Add missing task queue for opam loader and add those for new other new listers/loaders.
Rebase
Separate diff into two commits
Sep 28 2022
This is now deployed to production, closing this.
Looks good to me.