Page MenuHomeSoftware Heritage
Feed Advanced Search

Oct 4 2022

anlambert created P1477 (An Untitled Masterwork).
Oct 4 2022, 9:16 PM
anlambert requested review of D8616: cpan: Align loader implementation with latest lister improvements.
Oct 4 2022, 5:28 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8616: cpan: Align loader implementation with latest lister improvements.
Oct 4 2022, 5:24 PM · CPAN lister, Archive coverage
anlambert requested review of D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Oct 4 2022, 5:22 PM
anlambert added a revision to T2833: cpan.loader - archive Perl modules from CPAN: D8615: cpan: Improve listing process by querying the metacpan release endpoint.
Oct 4 2022, 5:17 PM · CPAN lister, Archive coverage
anlambert added inline comments to D8614: nixguix: Add support for listing origins with "recursive" integrity.
Oct 4 2022, 5:01 PM
anlambert accepted D8612: nixguix: Add support for pseudo url with missing schema.
Oct 4 2022, 4:43 PM
anlambert closed D8613: test: Deduplicate tests implementation for loader tasks creation.
Oct 4 2022, 4:22 PM
anlambert committed rDLDBASEb26b98810d54: test: Deduplicate tests implementation for loader tasks creation (authored by anlambert).
test: Deduplicate tests implementation for loader tasks creation
Oct 4 2022, 4:22 PM
anlambert requested review of D8613: test: Deduplicate tests implementation for loader tasks creation.
Oct 4 2022, 4:10 PM
anlambert accepted D8611: nixguix: Deal with connection error with server.
Oct 4 2022, 3:48 PM
anlambert accepted D8607: nixguix: Deal with impossible communication with server.
Oct 4 2022, 2:33 PM
anlambert accepted D8606: nixguix: Deal with mistyped origins.
Oct 4 2022, 2:32 PM
anlambert created P1473 nix recursive hash computation.
Oct 4 2022, 2:09 PM
anlambert accepted D8341: Add nixguix lister.

Looks good to me, better fixing issues that might araise when testing the lister in new diffs.

Oct 4 2022, 1:52 PM
anlambert edited P1472 (An Untitled Masterwork).
Oct 4 2022, 1:47 PM
anlambert created P1472 (An Untitled Masterwork).
Oct 4 2022, 1:47 PM
anlambert created P1471 (An Untitled Masterwork).
Oct 4 2022, 1:31 PM
anlambert added inline comments to D8606: nixguix: Deal with mistyped origins.
Oct 4 2022, 1:29 PM
anlambert added inline comments to D8379: Hackage: Loads Hackage Listed origins.
Oct 4 2022, 10:59 AM
anlambert accepted D8601: {Content|Directory}Loader: Register tasks.

Looks good to me, makes me think that I should deduplicate the tests for the tasks created from ListedOrigins in loaders through a fixture and add missing ones, I will push a diff for that.

Oct 4 2022, 10:53 AM

Oct 3 2022

anlambert added inline comments to D8341: Add nixguix lister.
Oct 3 2022, 4:28 PM
anlambert closed D8602: pre-commit: Fix tests data exclusion from codespell check.
Oct 3 2022, 4:12 PM
anlambert committed rDLDBASEc631349aea8f: pre-commit: Fix tests data exclusion from codespell check (authored by anlambert).
pre-commit: Fix tests data exclusion from codespell check
Oct 3 2022, 4:12 PM
anlambert requested review of D8602: pre-commit: Fix tests data exclusion from codespell check.
Oct 3 2022, 4:00 PM
anlambert closed D8600: cli: Use memory storage as fallback when no configuration detected.
Oct 3 2022, 3:35 PM
anlambert committed rDLDBASE13e9bf4d698d: cli: Use memory storage as fallback when no configuration detected (authored by anlambert).
cli: Use memory storage as fallback when no configuration detected
Oct 3 2022, 3:35 PM
anlambert updated the diff for D8600: cli: Use memory storage as fallback when no configuration detected.

Use warning log level instead of info.

Oct 3 2022, 3:31 PM
anlambert requested review of D8600: cli: Use memory storage as fallback when no configuration detected.
Oct 3 2022, 3:22 PM
anlambert closed D8596: package/utils: Fix download function documentation.
Oct 3 2022, 3:14 PM
anlambert committed rDLDBASEf6a3ed11b4f8: package/utils: Fix download function documentation (authored by anlambert).
package/utils: Fix download function documentation
Oct 3 2022, 3:14 PM
anlambert requested changes to D8601: {Content|Directory}Loader: Register tasks.

I recalled it is also important to test the loader parameters when created from ListedOrigin instances so I have added this test below:

diff --git a/swh/loader/core/tests/test_tasks.py b/swh/loader/core/tests/test_tasks.py
index bf8d2e1..c0ab361 100644
--- a/swh/loader/core/tests/test_tasks.py
+++ b/swh/loader/core/tests/test_tasks.py
@@ -3,8 +3,13 @@
 # License: GNU General Public License version 3, or any later version
 # See top-level LICENSE file for more information
Oct 3 2022, 3:12 PM
anlambert updated the diff for D8596: package/utils: Fix download function documentation.

rebase

Oct 3 2022, 2:53 PM
anlambert updated the diff for D8596: package/utils: Fix download function documentation.

Rebase

Oct 3 2022, 2:50 PM
anlambert requested review of D8596: package/utils: Fix download function documentation.
Oct 3 2022, 2:46 PM
anlambert added inline comments to D8587: {Content|Directory}Loader: Adapt support for checksums.
Oct 3 2022, 2:32 PM
anlambert added inline comments to D8566: Conda: Anaconda packages archive loader.
Oct 3 2022, 2:08 PM
anlambert accepted D8598: Fix compatibility issue with latest dependency version.
Oct 3 2022, 2:01 PM
anlambert added inline comments to D8598: Fix compatibility issue with latest dependency version.
Oct 3 2022, 1:56 PM
anlambert accepted D8589: api/asynchronous: Do not log/report client exceptions.
Oct 3 2022, 12:34 PM
anlambert added inline comments to D8587: {Content|Directory}Loader: Adapt support for checksums.
Oct 3 2022, 12:02 PM
anlambert accepted D8584: Add Directory Loader to allow tarball ingestion as Directory.

Looks good to me !

Oct 3 2022, 11:49 AM
anlambert closed D8595: Use tarball checksum to check download integrity in package loaders.
Oct 3 2022, 10:55 AM
anlambert committed rDLDBASE5482a48ea1bd: Use tarball checksum to check download integrity in package loaders (authored by anlambert).
Use tarball checksum to check download integrity in package loaders
Oct 3 2022, 10:55 AM
anlambert closed D8594: Send package artifact checksums to loaders when info is available.
Oct 3 2022, 10:54 AM
anlambert committed rDLSfa1205c4dfb6: Send package artifact checksums to loaders when info is available (authored by anlambert).
Send package artifact checksums to loaders when info is available
Oct 3 2022, 10:54 AM

Sep 30 2022

anlambert requested review of D8595: Use tarball checksum to check download integrity in package loaders.
Sep 30 2022, 6:52 PM
anlambert requested review of D8594: Send package artifact checksums to loaders when info is available.
Sep 30 2022, 6:51 PM
anlambert added inline comments to D8379: Hackage: Loads Hackage Listed origins.
Sep 30 2022, 6:02 PM
anlambert added inline comments to D8584: Add Directory Loader to allow tarball ingestion as Directory.
Sep 30 2022, 5:30 PM
anlambert added inline comments to D8584: Add Directory Loader to allow tarball ingestion as Directory.
Sep 30 2022, 5:19 PM
anlambert added inline comments to D8584: Add Directory Loader to allow tarball ingestion as Directory.
Sep 30 2022, 4:52 PM
anlambert closed D8585: svn: Add support to basic subversion authentication in SvnRepo.
Sep 30 2022, 4:47 PM
anlambert committed rDLDSVN8e735c953ba5: svn: Add support to basic subversion authentication in SvnRepo (authored by anlambert).
svn: Add support to basic subversion authentication in SvnRepo
Sep 30 2022, 4:47 PM
anlambert requested changes to D8379: Hackage: Loads Hackage Listed origins.

LGTM, just a couple of nitpicks to handle and I will accept it.

Sep 30 2022, 4:37 PM
anlambert requested changes to D8566: Conda: Anaconda packages archive loader.

LGTM, two small comments to handle before I can accept it.

Sep 30 2022, 4:26 PM
anlambert added a comment to D8379: Hackage: Loads Hackage Listed origins.

@franckbret , you updated the wrong diff (conda instead of hackage)

Sep 30 2022, 4:15 PM
anlambert closed D8586: hashutil: Add sha512 support in MultiHash class.
Sep 30 2022, 3:23 PM
anlambert committed rDMOD9b8beef15819: hashutil: Add sha512 support in MultiHash class (authored by anlambert).
hashutil: Add sha512 support in MultiHash class
Sep 30 2022, 3:23 PM
anlambert updated the diff for D8586: hashutil: Add sha512 support in MultiHash class.

Improve tests

Sep 30 2022, 3:18 PM
anlambert requested review of D8586: hashutil: Add sha512 support in MultiHash class.
Sep 30 2022, 3:02 PM
anlambert updated the diff for D8585: svn: Add support to basic subversion authentication in SvnRepo.

Address @vlorentz comments.

Sep 30 2022, 2:38 PM
anlambert accepted D8579: http_client: Add max_matching_nodes parameter to visit_nodes().
Sep 30 2022, 2:37 PM
anlambert added inline comments to D8579: http_client: Add max_matching_nodes parameter to visit_nodes().
Sep 30 2022, 2:22 PM
anlambert accepted D8583: SimpleTraversal.visitNode: Remove redundant boolean.
Sep 30 2022, 2:18 PM
anlambert requested review of D8585: svn: Add support to basic subversion authentication in SvnRepo.
Sep 30 2022, 2:17 PM
anlambert added a project to T4590: swh-scanner - improve distribution, documentation and usability: Code scanner.
Sep 30 2022, 2:16 PM · Code scanner
anlambert added a project to T4592: swh-scanner - generic bug fixing, robustness and performance improvements: Code scanner.
Sep 30 2022, 2:16 PM · Code scanner

Sep 29 2022

anlambert added inline comments to D8582: Allow more checksum computations in Content model.
Sep 29 2022, 7:42 PM
anlambert added inline comments to D8379: Hackage: Loads Hackage Listed origins.
Sep 29 2022, 6:28 PM
anlambert added a comment to D8379: Hackage: Loads Hackage Listed origins.

Here the problems is that the cabal file isn't formatted as the naïve parser expect.. we expect each line to be something like {k}: {v}\n but in this case its {k}: \n \t {v} \n and we end with an empty value..

Sep 29 2022, 6:10 PM
anlambert added inline comments to D8569: Add rubygems loader.
Sep 29 2022, 5:57 PM
anlambert closed D8535: docker/conf: Declare task queues for new listers and loaders.
Sep 29 2022, 5:33 PM
anlambert committed rDENVa68096ee1427: docker/conf: Declare task queues for new/missing listers and loaders (authored by anlambert).
docker/conf: Declare task queues for new/missing listers and loaders
Sep 29 2022, 5:33 PM
anlambert updated the diff for D8535: docker/conf: Declare task queues for new listers and loaders.

Add missing task queue for opam loader and add those for new other new listers/loaders.

Sep 29 2022, 5:32 PM
anlambert closed D8536: Update instructions for running a lister in docker.
Sep 29 2022, 11:35 AM
anlambert committed rDLSdabb1a2ae5b9: Update instructions for running a lister in docker (authored by anlambert).
Update instructions for running a lister in docker
Sep 29 2022, 11:35 AM
anlambert updated the diff for D8536: Update instructions for running a lister in docker.

Rebase

Sep 29 2022, 11:27 AM
anlambert committed rDLS5426883c49ce: debian: Remove no longer needed code to get accurate origins count (authored by anlambert).
debian: Remove no longer needed code to get accurate origins count
Sep 29 2022, 11:26 AM
anlambert closed D8565: pattern: Ensure accurate origin counts returned by run method.
Sep 29 2022, 11:26 AM
anlambert committed rDLS8d85b2e4e8d5: pattern: Ensure accurate origin counts returned by run method (authored by anlambert).
pattern: Ensure accurate origin counts returned by run method
Sep 29 2022, 11:26 AM
anlambert added inline comments to D8576: conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed.
Sep 29 2022, 11:25 AM
anlambert triaged T4580: Puppet Loader as Normal priority.
Sep 29 2022, 11:19 AM · Puppet loader
anlambert created Puppet loader.
Sep 29 2022, 11:19 AM
anlambert edited projects for T4581: RubyGems loader, added: RubyGems loader; removed RubyGems lister.
Sep 29 2022, 11:18 AM · RubyGems loader, Archive coverage
anlambert created RubyGems loader.
Sep 29 2022, 11:18 AM
anlambert updated the diff for D8565: pattern: Ensure accurate origin counts returned by run method.

Separate diff into two commits

Sep 29 2022, 11:16 AM
anlambert added inline comments to D8565: pattern: Ensure accurate origin counts returned by run method.
Sep 29 2022, 11:09 AM

Sep 28 2022

anlambert closed D8573: discovery: Fix compatibility with storage RPC API.
Sep 28 2022, 8:38 PM
anlambert committed rDLDBASE7375a83c2fba: discovery: Fix compatibility with storage RPC API (authored by anlambert).
discovery: Fix compatibility with storage RPC API
Sep 28 2022, 8:38 PM
anlambert requested review of D8573: discovery: Fix compatibility with storage RPC API.
Sep 28 2022, 8:31 PM
anlambert added a project to T4579: Create Conda Loader: Conda loader.
Sep 28 2022, 6:17 PM · Conda loader
anlambert created Conda loader.
Sep 28 2022, 6:17 PM
anlambert closed T4552: Add link to search for origins loaded from an add forge now request as Resolved.

This is now deployed to production, closing this.

Sep 28 2022, 6:16 PM · Web app, Add Forge Now
anlambert requested review of D8565: pattern: Ensure accurate origin counts returned by run method.
Sep 28 2022, 4:11 PM
anlambert accepted D8563: retry: Do not retry on SystemExit exceptions.
Sep 28 2022, 3:47 PM
anlambert accepted D8562: Add filters for the latestVisit field in an Origin.

Looks good to me.

Sep 28 2022, 3:46 PM
anlambert committed rDWAPPS6303a8942277: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Sep 28 2022, 3:40 PM
anlambert closed D8560: add_forge_now: Add useful links in requests tables.
Sep 28 2022, 3:40 PM
anlambert committed rDWAPPS7b2edb8504e3: add_forge_now: Add useful links in requests tables (authored by anlambert).
add_forge_now: Add useful links in requests tables
Sep 28 2022, 3:40 PM