Paths

Table of Contentst

Differential D8598

Fix compatibility issue with latest dependency version
ClosedPublic
Actions

Authored by ardumont on Oct 3 2022, 1:49 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSCH17c6d488168b: Fix compatibility issue with latest dependency version

Summary

This currently fails all swh related builds which depend on the celery/kombu stack due
to that dependency's latest version release.

When this lands, release a new scheduler version should subside all the other build
issues.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 3 2022, 1:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 3 2022, 1:49 PM

vlorentz added a subscriber: vlorentz.Oct 3 2022, 1:52 PM

vlorentz added inline comments.

requirements.txt
8–9

and it's not in alphabetical order

Build is green

Patch application report for D8598 (id=31050)

Rebasing onto 6d0b1d1e1a...

Current branch diff-target is up to date.

Changes applied before test

commit 09eaba5058483e858ba61edee9af9b464aa00b35
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 3 13:43:32 2022 +0200

    Restrict importlib_metadata to a non-breaking version
    
    This currently fails all swh related builds which depend on the celery/kombu stack due
    to that dependency's latest version release.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/562/ for more details.

Harbormaster completed remote builds in B32020: Diff 31050.Oct 3 2022, 1:54 PM

ardumont requested review of this revision.Oct 3 2022, 1:54 PM

anlambert added a subscriber: anlambert.Oct 3 2022, 1:56 PM

anlambert added inline comments.

requirements.txt
8–9	Also could you add spaces around `<` ?

ack on what you said both ;)

alphabetical order

yeah, i put it under the main one pulling all the deps.
will amend.

Adapt according to reviews

ardumont marked 2 inline comments as done.Oct 3 2022, 1:59 PM

ardumont retitled this revision from Restrict importlib_metadata to a non-breaking version to Fix compatibility issue with latest dependency version.

anlambert accepted this revision.Oct 3 2022, 2:01 PM

This revision is now accepted and ready to land.Oct 3 2022, 2:01 PM

This revision was landed with ongoing or failed builds.Oct 3 2022, 2:01 PM

Closed by commit rDSCH17c6d488168b: Fix compatibility issue with latest dependency version (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH17c6d488168b: Fix compatibility issue with latest dependency version.

Tag and released v1.2.3, jenkins up to you now, tia!

Build is green

Patch application report for D8598 (id=31052)

Rebasing onto 6d0b1d1e1a...

Current branch diff-target is up to date.

Changes applied before test

commit 17c6d488168b273b7919425447b2b965a754e113
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Oct 3 13:43:32 2022 +0200

    Fix compatibility issue with latest dependency version
    
    This currently fails all swh related builds which depend on the celery/kombu stack due
    to that dependency's latest version release.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/563/ for more details.

Harbormaster completed remote builds in B32022: Diff 31052.Oct 3 2022, 2:03 PM