add_forge_now: Add useful links in requests tables
ClosedPublic
Actions

Authored by anlambert on Sep 28 2022, 11:57 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4552: Add link to search for origins loaded from an add forge now request

Commits

rDWAPPS7b2edb8504e3: add_forge_now: Add useful links in requests tables

Summary

In public requests table and moderation one, add a link to search for
origins loaded from a forge once request status is FIRST_ORIGIN_LOADED.

Also add a more visual link to navigate to request moderation page
in requests moderation table.

Related to T4552

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 28 2022, 11:57 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 28 2022, 11:57 AM

Build is green

Patch application report for D8560 (id=30882)

Rebasing onto 4a03dc7bf6...

Current branch diff-target is up to date.

Changes applied before test

commit 7b2edb8504e337ea68b672a413021bd54fb11c0b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Sep 28 11:47:02 2022 +0200

    add_forge_now: Add useful links in requests tables
    
    In public requests table and moderation one, add a link to search for
    origins loaded from a forge once request status is FIRST_ORIGIN_LOADED.
    
    Also add a more visual link to navigate to request moderation page
    in requests moderation table.
    
    Related to T4552

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2075/ for more details.

Harbormaster completed remote builds in B31853: Diff 30882.Sep 28 2022, 12:06 PM

anlambert requested review of this revision.Sep 28 2022, 12:06 PM

lgtm

Although, i only skimmed through the code. I was mostly sold by the screenshots ¯\_(ツ)_/¯.

swh/web/add_forge_now/assets/create-request.js
131	jsyk, there is a `genLink` util function to ease the a link generation iirc (see line 113 above). That may need some update inside though, idk.

ardumont accepted this revision.Sep 28 2022, 1:32 PM

This revision is now accepted and ready to land.Sep 28 2022, 1:32 PM

anlambert added inline comments.Sep 28 2022, 1:54 PM

swh/web/add_forge_now/assets/create-request.js
131	`genLink` is useful for simple links but for this case it would need some adaptations and code will not be so readable as we cannot use named parameters easily with js, so I would land that diff in its current state.