Differential D8602

pre-commit: Fix tests data exclusion from codespell check
ClosedPublic
Actions

Authored by anlambert on Oct 3 2022, 3:56 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASEc631349aea8f: pre-commit: Fix tests data exclusion from codespell check

Summary

Previous regexp does not seem to work anymore so use a simpler one.

15:54 $ make check 
pre-commit run --all-files
trim trailing whitespace.................................................Passed
check json...............................................................Passed
check yaml...............................................................Passed
flake8...................................................................Passed
Check source code spelling...............................................Failed
- hook id: codespell
- exit code: 65

swh/loader/package/npm/tests/data/https_replicate.npmjs.com/nativescript-telerik-analytics:60: nIn ==> inn, min, bin, nine
swh/loader/package/aur/tests/data/fake_aur.sh:91: Toi ==> To, toy
swh/loader/package/pubdev/tests/data/https_pub.dev/api_packages_abstract_io:7: externaly ==> externally
swh/loader/package/pubdev/tests/data/https_pub.dev/api_packages_abstract_io:30: externaly ==> externally
swh/loader/package/pubdev/tests/data/https_pub.dev/api_packages_abstract_io:52: externaly ==> externally
swh/loader/package/pubdev/tests/data/https_pub.dev/api_packages_abstract_io:74: externaly ==> externally
swh/loader/package/debian/tests/data/http_deb.debian.org/debian_pool_contrib_c_cicero_cicero_0.7.2-4.dsc:11: infinit ==> infinite
swh/loader/package/debian/tests/data/http_deb.debian.org/debian_pool_contrib_c_cicero_cicero_0.7.2-3.dsc:11: infinit ==> infinite
swh/loader/package/pubdev/tests/data/fake_pubdev.sh:14: thier ==> their

mypy.....................................................................Passed
isort....................................................................Passed
black....................................................................Passed
make: *** [../Makefile.python:28: check] Error 1

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 3 2022, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 3 2022, 3:56 PM

Build is green

Patch application report for D8602 (id=31068)

Rebasing onto 13e9bf4d69...

Current branch diff-target is up to date.

Changes applied before test

commit c631349aea8f6d5e8f7a2c4be2a1ee795270f244
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 3 15:52:16 2022 +0200

    pre-commit: Fix tests data exclusion from codespell check
    
    Previous regexp does not seem to work anymore so use a simpler one.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/950/ for more details.

Harbormaster completed remote builds in B32038: Diff 31068.Oct 3 2022, 4:00 PM

anlambert requested review of this revision.Oct 3 2022, 4:00 PM

ardumont accepted this revision.Oct 3 2022, 4:10 PM

This revision is now accepted and ready to land.Oct 3 2022, 4:10 PM

Closed by commit rDLDBASEc631349aea8f: pre-commit: Fix tests data exclusion from codespell check (authored by anlambert). · Explain WhyOct 3 2022, 4:12 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASEc631349aea8f: pre-commit: Fix tests data exclusion from codespell check.