typo + forgot the requirement file
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 26 2022
rephrase (journal usage by the scheduler)
In D7647#200113, @olasd wrote:In D7647#200065, @vlorentz wrote:Thanks. On the diagram, it looks like 9' is causing 12 (via 10 and 11), which is not true (yet! D7332 isn't agreed upon) and could be very confusing.
This is because 9' writes to the origin_visit table, but 10/11/12 are based on the origin table/topic.
Could you split swh-storage in two, to avoid this misunderstanding?
To clear the misunderstanding maybe the label for 10 could be Consume final "origin visit status" entries?
typos and better rst syntax as suggested by vlorentz
typos
In D7652#199523, @ardumont wrote:lgtm
couple of typos to fix.
Apr 25 2022
Apr 21 2022
typo
rebase
thx vlorentz
thx vlorentz
Apr 20 2022
Improve docstrings, better config validation, use lists in grab_next_visits_policy_weights()
Use a flatter config structure
Apr 15 2022
Improve and simplify a bit the code
typo (thx ardumont)
Apr 14 2022
lgtm, maybe add a comment in test_cli.py to justify the presence of forked over there
Apr 13 2022
Apr 12 2022
lgtm
Apr 11 2022
rebase
Add type annotation for SWH_MODEL_OBJECT_TYPES
Apr 8 2022
Apr 7 2022
rebase
Apr 6 2022
As I said, I'm not completely enthusiastic by this code (especially the lack of flexibility and versatility to provision for other origin sources than git) but it's a nice start at least.
Thanks
rebase
adapt code according to anlambert's suggestion
I think I'd prefer not to have 3 versions of almost the same function (corrupt_object_(get|grab_xxx) ).
Apr 5 2022
lgtm but I'm not sure to understand what's at stake here.
specify aptitude is to be used only when needed (sic)
In D7039#194101, @ardumont wrote:Ping, what do we do with this diff?
In D7039#183041, @douardda wrote:In D7039#183023, @olasd wrote:You could add a list of useful third party repositories pulled from https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/templates/debian/gbp-buildpackage.groovy.j2$122-150
good thinking
typos (thx ardumont) + add a warning about db migration
In D7465#196093, @vlorentz wrote:LGTM, but we should eventually replace self.objstorage.get() with self.objstorage.get_batch(), it is much faster with the Azure backend (and hopefully more backends in the future, inc. Winery!)
Apr 4 2022
fix indentation and do only call 'yarn build-dev'
better docstring (thx olasd)
docstring
In D7473#195294, @vlorentz wrote:Please add a docstring; it's unclear this is used by swh-core otherwise
In D7472#195801, @olasd wrote:The duplication between db_transaction and db_transaction_generator looks a bit silly, but I'm not sure there's much to do about it, so this lgtm, thanks.
wrong head...