Differential D7519

Reduce cli's loading time by moving import statements in commands
ClosedPublic
Actions

Authored by douardda on Apr 7 2022, 12:03 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDATASET18325cc8e78e: Reduce cli's loading time by moving import statements in commands

Diff Detail

Repository

rDDATASET Datasets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 7 2022, 12:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2022, 12:03 PM

douardda added a child revision: D7520: Add a ORC file loading function.Apr 7 2022, 12:04 PM

Build is green

Patch application report for D7519 (id=27282)

Rebasing onto 9d97f0c082...

Current branch diff-target is up to date.

Changes applied before test

commit 18325cc8e78e99ac35f550687e41b6f21c5d3a9f
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Apr 6 16:16:09 2022 +0200

    Reduce cli's loading time by moving import statements in commands

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/124/ for more details.

Harbormaster completed remote builds in B28212: Diff 27282.Apr 7 2022, 12:05 PM

douardda requested review of this revision.Apr 7 2022, 12:05 PM

thanks.

Same player plays again (you did that in other modules back in the day ;)

This revision is now accepted and ready to land.Apr 7 2022, 2:37 PM

vlorentz added a subscriber: vlorentz.Apr 7 2022, 2:56 PM

vlorentz added inline comments.

swh/dataset/cli.py
16	why not this one too?

douardda added inline comments.Apr 8 2022, 11:36 AM

swh/dataset/cli.py
16	because it's used to fill a click.Choice() argument... in a following revision :-) (plus it's really just a bunch of dicts declarations).

Closed by commit rDDATASET18325cc8e78e: Reduce cli's loading time by moving import statements in commands (authored by douardda). · Explain WhyApr 8 2022, 11:48 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDDATASET18325cc8e78e: Reduce cli's loading time by moving import statements in commands.

Revision Contents
Changeset List

Path

Size

swh/

dataset/

cli.py

42 lines

Diff 27318

View Options

Reduce cli's loading time by moving import statements in commandsClosedPublicActions