Differential D7552

origin_get_with_statuses: Fix case when fetched visits list is empty
ClosedPublic
Actions

Authored by anlambert on Apr 12 2022, 12:10 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T4090: Add method to efficiently retrieve latest statuses of origin visits

Commits

rDSTOd255fb3c8a41: origin_get_with_statuses: Fix case when fetched visits list is empty

Summary

Ensure to return an empty list of results when fetched visits list is
empty, for instance when the provided page_token is greater or equal
to latest origin visit.

Related to T4090

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 12 2022, 12:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 12 2022, 12:10 PM

anlambert added a child revision: D7553: origin_get_with_statuses: Rename RPC endpoint path.Apr 12 2022, 12:16 PM

Build is green

Patch application report for D7552 (id=27381)

Rebasing onto 7c9586a0bb...

Current branch diff-target is up to date.

Changes applied before test

commit d255fb3c8a419cff80305990aae99d87e1d9b894
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Apr 12 12:06:14 2022 +0200

    origin_get_with_statuses: Fix case when fetched visits list is empty
    
    Ensure to return an empty list of results when fetched visits list is
    empty, for instance when the provided page_token is greater or equal
    to latest origin visit.
    
    Related to T4090

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1590/ for more details.

Harbormaster completed remote builds in B28393: Diff 27381.Apr 12 2022, 12:21 PM

anlambert requested review of this revision.Apr 12 2022, 12:21 PM

douardda accepted this revision.Apr 12 2022, 12:26 PM

This revision is now accepted and ready to land.Apr 12 2022, 12:26 PM

Closed by commit rDSTOd255fb3c8a41: origin_get_with_statuses: Fix case when fetched visits list is empty (authored by anlambert). · Explain WhyApr 12 2022, 2:13 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDSTOd255fb3c8a41: origin_get_with_statuses: Fix case when fetched visits list is empty.