Differential D7692

Make swh.objstorage an optional dependency, as a 'with-content' extra
ClosedPublic
Actions

Authored by douardda on Apr 26 2022, 5:53 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDATASET157331b9ae66: Make swh.objstorage an optional dependency, as a 'with-content' extra

Diff Detail

Repository

rDDATASET Datasets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 26 2022, 5:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 26 2022, 5:53 PM

Build is green

Patch application report for D7692 (id=27791)

Rebasing onto 755c903bd3...

Current branch diff-target is up to date.

Changes applied before test

commit ec95782ecbe197e33e81c49100e812f17dfef916
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 26 17:38:40 2022 +0200

    Make swh.objstorage an optional dependency, as a 'with-content' extra

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/139/ for more details.

Harbormaster completed remote builds in B28853: Diff 27791.Apr 26 2022, 5:55 PM

douardda requested review of this revision.Apr 26 2022, 5:55 PM

ardumont added a subscriber: ardumont.Apr 26 2022, 5:57 PM

ardumont added inline comments.

swh/dataset/exporters/orc.py
41

typo + forgot the requirement file

douardda marked an inline comment as done.Apr 26 2022, 6:01 PM

douardda added inline comments.

swh/dataset/exporters/orc.py
41	jeez. thx

douardda marked an inline comment as done.Apr 26 2022, 6:02 PM

Build is green

Patch application report for D7692 (id=27792)

Rebasing onto 755c903bd3...

Current branch diff-target is up to date.

Changes applied before test

commit 157331b9ae6670f6ee0071de7ea1db2577b0b3ff
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 26 17:38:40 2022 +0200

    Make swh.objstorage an optional dependency, as a 'with-content' extra

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/140/ for more details.

Harbormaster completed remote builds in B28854: Diff 27792.Apr 26 2022, 6:03 PM

As usual, i'm pretty much out of my depth with those kind of diffs.
What's the expected impacts regarding the current debian packaging?
Shall we need to update something there?

(But otherwise, that looks good, thanks).

no impact says the david, fine, moving along then ;)

Thanks.

This revision is now accepted and ready to land.Apr 26 2022, 6:07 PM

Closed by commit rDDATASET157331b9ae66: Make swh.objstorage an optional dependency, as a 'with-content' extra (authored by douardda). · Explain WhyApr 26 2022, 6:09 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDDATASET157331b9ae66: Make swh.objstorage an optional dependency, as a 'with-content' extra.