Page MenuHomeSoftware Heritage

Clean up `model` removing old unused logic
AbandonedPublic

Authored by douardda on Mar 31 2022, 3:25 PM.

Details

Reviewers
aeviso
Group Reviewers
Reviewers
Summary

Depends on D7477

Diff Detail

Event Timeline

Build is green

Patch application report for D7478 (id=27133)

Could not rebase; Attempt merge onto 16723f8be4...

Updating 16723f8..3cd9b1c
Fast-forward
 swh/provenance/__init__.py                     |  3 ++-
 swh/provenance/model.py                        | 16 ++++++--------
 swh/provenance/swhgraph/archive.py             | 27 ++++++++++++++++++------
 swh/provenance/tests/test_archive_interface.py | 29 ++++++++++----------------
 4 files changed, 40 insertions(+), 35 deletions(-)
Changes applied before test
commit 3cd9b1cab2ec5e2a9da92e026bfa816d07c30404
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 15:23:56 2022 +0200

    Clean up `model` removing old unused logic

commit 67d7c5733e9b4648b3fb07918b69107fc6bcd036
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 12:16:19 2022 +0200

    Fix `get_archive` to avoid `storage` parameter for `ArchiveGraph`

commit 9f77e41049f268ae388f0a1b77cfa7a0c3b49e32
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 11:42:47 2022 +0200

    Improve `revision_get_parents` implementation in `ArchiveGraph`
    
    When a revision is passed, it now retrieves and caches the complete
    history three to minimize the queries to the graph.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/590/ for more details.

Build is green

Patch application report for D7478 (id=27134)

Could not rebase; Attempt merge onto 16723f8be4...

Updating 16723f8..f76fffb
Fast-forward
 swh/provenance/__init__.py                     |  3 ++-
 swh/provenance/model.py                        | 18 +++++++---------
 swh/provenance/swhgraph/archive.py             | 27 ++++++++++++++++++------
 swh/provenance/tests/test_archive_interface.py | 29 ++++++++++----------------
 4 files changed, 42 insertions(+), 35 deletions(-)
Changes applied before test
commit f76fffb6463efd33dd187c06710d720bc2370171
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 15:23:56 2022 +0200

    Clean up `model` removing old unused logic

commit 67d7c5733e9b4648b3fb07918b69107fc6bcd036
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 12:16:19 2022 +0200

    Fix `get_archive` to avoid `storage` parameter for `ArchiveGraph`

commit 9f77e41049f268ae388f0a1b77cfa7a0c3b49e32
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Mar 31 11:42:47 2022 +0200

    Improve `revision_get_parents` implementation in `ArchiveGraph`
    
    When a revision is passed, it now retrieves and caches the complete
    history three to minimize the queries to the graph.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/591/ for more details.

This revision is now accepted and ready to land.Mar 31 2022, 3:54 PM
douardda edited reviewers, added: aeviso; removed: douardda.
This revision now requires review to proceed.Oct 13 2022, 4:37 PM