Page MenuHomeSoftware Heritage
Differential D7506

Add support for HAL-ID as identifier
ClosedPublic
Actions

Authored by vlorentz on Apr 5 2022, 3:41 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Maniphest Tasks
T3965: deposit: Validate Atom documents are well-formed
Commits
rDDEP6d1089cb25b6: Add support for HAL-ID as identifier

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 5 2022, 3:41 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 5 2022, 3:41 PM
swh-public-ci added a comment.Apr 5 2022, 3:47 PM

Build is green

Patch application report for D7506 (id=27226)

Rebasing onto bb5c6b55f2...

Current branch diff-target is up to date.
Changes applied before test
commit f9bee1a1850f42aca5eb21a2339a0e43de78e516
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 5 15:40:52 2022 +0200

    Add support for HAL-ID as identifier

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/828/ for more details.

Harbormaster completed remote builds in B28129: Diff 27226.Apr 5 2022, 3:47 PM
vlorentz requested review of this revision.Apr 5 2022, 3:47 PM
douardda added a subscriber: douardda.Apr 5 2022, 5:01 PM

lgtm but I'm not sure to understand what's at stake here.

vlorentz added a comment.Apr 6 2022, 10:53 AM

not much; we already got HAL-IDs as identifiers, so any consumer of deposit metadata will need to deal with them anyway.

douardda accepted this revision.Apr 6 2022, 3:23 PM
This revision is now accepted and ready to land.Apr 6 2022, 3:23 PM
vlorentz updated this revision to Diff 27266.Apr 6 2022, 6:05 PM

rebase

This revision was landed with ongoing or failed builds.Apr 6 2022, 6:05 PM
Closed by commit rDDEP6d1089cb25b6: Add support for HAL-ID as identifier (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP6d1089cb25b6: Add support for HAL-ID as identifier.
swh-public-ci added a comment.Apr 6 2022, 6:13 PM

Build is green

Patch application report for D7506 (id=27266)

Rebasing onto 6d1089cb25...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-829-D7506.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/829/ for more details.
Harbormaster completed remote builds in B28194: Diff 27266.Apr 6 2022, 6:13 PM
vlorentz added a task: T3965: deposit: Validate Atom documents are well-formed.Apr 27 2022, 2:27 PM
Revision Contents
Changeset List
PathSize
swh/
deposit/
api/
38 lines
tests/
api/
32 lines
xsd/
14 lines
Diff 27267
View Options
swh/deposit/api/checks.py
Loading...
View Options
swh/deposit/tests/api/test_checks.py
Loading...
View Options
swh/deposit/xsd/codemeta.xsd
Loading...
About · Developer information · Legal