Page MenuHomeSoftware Heritage
Feed Advanced Search

Mar 14 2022

olasd updated the diff for D7325: Bootstrap a common app for management of inbound emails.

Apply comments on utilities

Mar 14 2022, 1:26 PM
olasd updated the diff for D7325: Bootstrap a common app for management of inbound emails.
  • migrate stderr usage to more controllable logging statements
  • introduce tests for most behaviors of the module
Mar 14 2022, 1:22 PM

Mar 11 2022

olasd added inline comments to D7325: Bootstrap a common app for management of inbound emails.
Mar 11 2022, 3:53 PM
olasd accepted D7337: postgresql: Increase timeouts that often fail.

Yeah, that's fine.

Mar 11 2022, 3:08 PM
olasd added a comment to P1310 query plan origin_visit_get_latest.

(even sorting by the pk (origin_visit.origin, origin_visit.visit), postgres still sorts the output of the nested loop)

Mar 11 2022, 12:17 PM
olasd added a comment to P1310 query plan origin_visit_get_latest.

FWIW even when forcing the use of the origin.url unique index, there's a nested loop then a sort:

Mar 11 2022, 12:11 PM

Mar 10 2022

olasd added inline comments to D7321: WIP: Create Submission form w/basic info.
Mar 10 2022, 11:02 AM
olasd added inline comments to D7327: api: Add endpoint to update an add-forge request.
Mar 10 2022, 10:38 AM

Mar 9 2022

olasd requested review of D7325: Bootstrap a common app for management of inbound emails.
Mar 9 2022, 6:11 PM
olasd added a revision to T3999: [Add forge now] Design a feedback tracking solution: D7325: Bootstrap a common app for management of inbound emails.
Mar 9 2022, 5:58 PM · Add Forge Now
olasd added a revision to T3999: [Add forge now] Design a feedback tracking solution: D7326: Hook up processing of inbound emails for add_forge_now.
Mar 9 2022, 5:57 PM · Add Forge Now
olasd added a comment to T4025: Email delivery issues from tate.softwareheritage.org (phabricator, mediawikis) to GMail.

I've tried adding gandi and inria's outbound mail servers to @softwareheritage.org's SPF records.

Mar 9 2022, 4:06 PM · System administration
olasd added a comment to T4025: Email delivery issues from tate.softwareheritage.org (phabricator, mediawikis) to GMail.

References:

Mar 9 2022, 11:22 AM · System administration
olasd triaged T4025: Email delivery issues from tate.softwareheritage.org (phabricator, mediawikis) to GMail as High priority.
Mar 9 2022, 11:17 AM · System administration

Mar 8 2022

olasd changed the status of T3994: [Add forge now] Create "add forge now" dedicated email alias from Open to Work in Progress.
Mar 8 2022, 6:03 PM · Add Forge Now
olasd added a comment to T3994: [Add forge now] Create "add forge now" dedicated email alias .

We've deployed and tested these changes in staging and production: inbound emails to both addresses now reach the django management command, which does not exist (so the mails get bounced with an error message to that effect).

Mar 8 2022, 6:03 PM · Add Forge Now
olasd committed rSPSITE6ac7ec3a002e: smtp: execute newaliases when changing an extra aliases file (authored by olasd).
smtp: execute newaliases when changing an extra aliases file
Mar 8 2022, 6:01 PM
olasd committed rSPSITEf93b3117e350: smtp: add dependency between alias files and the associated mailalias resources (authored by olasd).
smtp: add dependency between alias files and the associated mailalias resources
Mar 8 2022, 5:54 PM
olasd committed rSPSITE7f08bb701b7f: smtp: puppet doesn't like duplicate mailalias resources for the same name (authored by olasd).
smtp: puppet doesn't like duplicate mailalias resources for the same name
Mar 8 2022, 5:48 PM
olasd committed rSPSITE96be6eda649b: smtp: ensure extra alias files are properly used (authored by olasd).
smtp: ensure extra alias files are properly used
Mar 8 2022, 5:41 PM
olasd committed rSPSITE7f482b81b5e4: webapp: create separate aliases files for inbound email (authored by olasd).
webapp: create separate aliases files for inbound email
Mar 8 2022, 5:36 PM
olasd committed rSPSITEa2e9fd301167: smtp: add support for extra aliases files not owned by root (authored by olasd).
smtp: add support for extra aliases files not owned by root
Mar 8 2022, 5:36 PM
olasd committed rSPSITE98be7078a2c3: Split smtp configuration into separate module (authored by olasd).
Split smtp configuration into separate module
Mar 8 2022, 5:36 PM
olasd committed rSPPFIX33ae52c10fa4: Add support for multiple aliases files (authored by olasd).
Add support for multiple aliases files
Mar 8 2022, 5:36 PM
olasd committed rSPSITE40f1c1b33724: smtp: Use proper argument order for django management commands (authored by olasd).
smtp: Use proper argument order for django management commands
Mar 8 2022, 4:52 PM
olasd added a comment to T3994: [Add forge now] Create "add forge now" dedicated email alias .

We have created the following (external) email aliases:

Mar 8 2022, 4:43 PM · Add Forge Now
olasd committed rSPSITE0ef2fdadf182: Add inbound email routing for swh-webapp (authored by olasd).
Add inbound email routing for swh-webapp
Mar 8 2022, 4:38 PM
olasd closed D7310: Add a moderator role for add forge now.
Mar 8 2022, 12:03 PM
olasd committed rSPSITE37a0ff4ec97e: Add a moderator role for add forge now (authored by olasd).
Add a moderator role for add forge now
Mar 8 2022, 12:03 PM
olasd requested review of D7310: Add a moderator role for add forge now.
Mar 8 2022, 12:00 PM
olasd added a revision to T4018: [Add forge now] Create a moderator role: D7310: Add a moderator role for add forge now.
Mar 8 2022, 12:00 PM · Add Forge Now

Mar 4 2022

olasd committed rSPSITE9740d146c3a4: Make nginx deployment more robust (authored by olasd).
Make nginx deployment more robust
Mar 4 2022, 8:24 PM
olasd triaged T4010: Deposit icinga checks should return a single status line and set of performance data as Wishlist priority.
Mar 4 2022, 8:05 PM · Easy hack, Icinga plugins
olasd added a comment to T3899: Clean nfs mountpoint on workers.

Done via e49f0136 and 1ef20592

Mar 4 2022, 8:02 PM · System administration
olasd committed rSPSITE1ef20592da6d: Drop /srv/storage/space on moma (authored by olasd).
Drop /srv/storage/space on moma
Mar 4 2022, 7:55 PM
olasd committed rSPSITEe49f01366b80: Add explicit /srv/storage/space/swh-deposit rw mountpoint to moma (authored by olasd).
Add explicit /srv/storage/space/swh-deposit rw mountpoint to moma
Mar 4 2022, 7:45 PM
olasd added a comment to T3899: Clean nfs mountpoint on workers.

Turns out moma uses the rw /srv/storage/space/swh-deposit mountpoint for deposits. I'll update puppet accordingly.

Mar 4 2022, 7:42 PM · System administration
olasd accepted D7305: deposit: Check the status code of the REMD API..

Kewl

Mar 4 2022, 6:59 PM
olasd accepted D7304: deposit: Properly escape URLs.

nom nom nom urlencoding by hand

Mar 4 2022, 6:59 PM
olasd closed T3983: Add monitoring of vault bundle downloads as Resolved.

This is now all used on pergamon for our e2e checks.

Mar 4 2022, 6:38 PM · System administration, Monitoring
olasd committed rSPSITE4c78439e31d3: Neutralize objstorage_ceph profile (authored by olasd).
Neutralize objstorage_ceph profile
Mar 4 2022, 6:18 PM
olasd accepted D7303: deposit: Fetch only metadata created after the check started.

Yeah, that's sensible :-)

Mar 4 2022, 6:12 PM
olasd accepted D7302: vault: Open tarballs in stream mode + add test for empty tar files.

Sounds fun.

Mar 4 2022, 6:12 PM
olasd accepted D7301: Remove useless HTTP header from tests.
Mar 4 2022, 6:11 PM
olasd committed rSPSITE1d00e4c05ac0: Add swh-web-url argument for deposit e2e check (authored by olasd).
Add swh-web-url argument for deposit e2e check
Mar 4 2022, 5:53 PM
olasd committed rSPSITE8d865eb44434: Update deposit end to end check arguments for swh.icinga_plugins 0.4.0 (authored by olasd).
Update deposit end to end check arguments for swh.icinga_plugins 0.4.0
Mar 4 2022, 5:43 PM
olasd accepted D7298: vault: Open the beginning of the tarball to check it makes sense..
Mar 4 2022, 5:18 PM
olasd updated the task description for T4009: Icinga checks should set a specific user agent.
Mar 4 2022, 5:09 PM · Icinga plugins, Easy hack
olasd triaged T4009: Icinga checks should set a specific user agent as Normal priority.
Mar 4 2022, 5:09 PM · Icinga plugins, Easy hack
olasd created Icinga plugins.
Mar 4 2022, 5:08 PM
olasd triaged T4008: Add a `versions` endpoint on RPC services as Normal priority.
Mar 4 2022, 5:02 PM · Easy hack, Core & foundations
olasd accepted D7298: vault: Open the beginning of the tarball to check it makes sense..

Yep, that looks good to me.

Mar 4 2022, 4:55 PM
olasd accepted D7300: vault: Check content-type.

Good idea, thanks!

Mar 4 2022, 4:52 PM
olasd accepted D7299: vault: Un-nest checks.
Mar 4 2022, 4:46 PM
olasd committed rDVAU7397110d444b: server: ensure check_config is called during app instantiation (authored by olasd).
server: ensure check_config is called during app instantiation
Mar 4 2022, 4:42 PM
olasd committed rDVAU456eb8f41967: server tests: refactor config fixtures to match production (authored by olasd).
server tests: refactor config fixtures to match production
Mar 4 2022, 4:42 PM
olasd committed rDVAU432bfdcdea52: conftest: drop deprecated args from objstorage initializers (authored by olasd).
conftest: drop deprecated args from objstorage initializers
Mar 4 2022, 4:42 PM
olasd closed D7296: server: ensure check_config is called during app instantiation.
Mar 4 2022, 4:42 PM
olasd added inline comments to D7296: server: ensure check_config is called during app instantiation.
Mar 4 2022, 4:41 PM
olasd added inline comments to D7296: server: ensure check_config is called during app instantiation.
Mar 4 2022, 4:36 PM
olasd added inline comments to D7296: server: ensure check_config is called during app instantiation.
Mar 4 2022, 4:13 PM
olasd added inline comments to D7296: server: ensure check_config is called during app instantiation.
Mar 4 2022, 4:10 PM
olasd added a comment to D7298: vault: Open the beginning of the tarball to check it makes sense..

Seems worth a rebase on top of D7264 too, but I guess it'll need some more changes

Mar 4 2022, 4:05 PM
olasd accepted D7297: Rename dir_id to DIR_ID.

this looks worth a rebase on top of D7264

Mar 4 2022, 4:03 PM
olasd closed D7264: vault: add monitoring of bundle downloads.
Mar 4 2022, 4:02 PM
olasd committed rDICPc698de271141: vault: add monitoring of bundle downloads (authored by olasd).
vault: add monitoring of bundle downloads
Mar 4 2022, 4:02 PM
olasd updated the diff for D7264: vault: add monitoring of bundle downloads.

rebase

Mar 4 2022, 4:00 PM
olasd accepted D7293: Finish removing aiohttp.
Mar 4 2022, 3:59 PM
olasd requested review of D7264: vault: add monitoring of bundle downloads.
Mar 4 2022, 3:49 PM
olasd merged task T4000: vault monitoring: check bundles can be downloaded into T3983: Add monitoring of vault bundle downloads.
Mar 4 2022, 3:45 PM · Monitoring, Vault
olasd merged T4000: vault monitoring: check bundles can be downloaded into T3983: Add monitoring of vault bundle downloads.
Mar 4 2022, 3:45 PM · System administration, Monitoring
olasd added a comment to T4000: vault monitoring: check bundles can be downloaded.

Already done in D7264...

Mar 4 2022, 3:44 PM · Monitoring, Vault
olasd added a comment to D7295: vault: Check bundle download from the public API..

D7264 ?

Mar 4 2022, 3:43 PM
olasd requested review of D7296: server: ensure check_config is called during app instantiation.
Mar 4 2022, 3:41 PM
olasd committed rSPSITEf3230d7fda7f: Revert "vault is still async for now" (authored by olasd).
Revert "vault is still async for now"
Mar 4 2022, 1:45 PM
olasd added a reverting change for rSPSITEb1cbb45927bd: vault is still async for now: rSPSITEf3230d7fda7f: Revert "vault is still async for now".
Mar 4 2022, 1:45 PM
olasd abandoned D7292: Ensure server tests and fixtures properly clean up the global flask app.

Folded into D7291

Mar 4 2022, 1:26 PM
olasd accepted D7291: Rewrite the server to use flask instead of aiohttp.

Great, thanks!

Mar 4 2022, 1:26 PM
olasd requested review of D7292: Ensure server tests and fixtures properly clean up the global flask app.
Mar 4 2022, 1:00 PM
olasd accepted D7284: deposit: Check metadata was archived verbatim.

Looks good, thank you!

Mar 4 2022, 10:51 AM
olasd accepted D7283: deposit: Filter out metadata objects created before the check started.
Mar 4 2022, 10:50 AM
olasd accepted D7278: deposit: Check created metadata is visible from the public API.

Nice, thanks.

Mar 4 2022, 10:49 AM

Mar 3 2022

olasd committed rDCOREae654de04ed7: api.RPCClient: replace use of deprecated post method in generated methods (authored by olasd).
api.RPCClient: replace use of deprecated post method in generated methods
Mar 3 2022, 8:22 PM
olasd closed D7290: api.RPCClient: replace use of deprecated post method in generated methods.
Mar 3 2022, 8:22 PM
olasd updated the diff for D7290: api.RPCClient: replace use of deprecated post method in generated methods.

rebase

Mar 3 2022, 8:20 PM
olasd updated the diff for D7290: api.RPCClient: replace use of deprecated post method in generated methods.

Track down more uses of rpc_client.post

Mar 3 2022, 8:03 PM
olasd closed D7289: use `objstorage is None` instead of `not objstorage`.
Mar 3 2022, 7:57 PM
olasd committed rDOBJS26201f451e8c: use `objstorage is None` instead of `not objstorage` (authored by olasd).
use `objstorage is None` instead of `not objstorage`
Mar 3 2022, 7:57 PM
olasd requested review of D7289: use `objstorage is None` instead of `not objstorage`.
Mar 3 2022, 7:56 PM
olasd committed rSPSITEb1cbb45927bd: vault is still async for now (authored by olasd).
vault is still async for now
Mar 3 2022, 6:55 PM
olasd committed rDOBJSe90ea3e2cfe5: api.server: only load config once, and keep basic flask config (authored by olasd).
api.server: only load config once, and keep basic flask config
Mar 3 2022, 6:51 PM
olasd committed rDOBJSb6e8230cdfc5: Mark lower bound for typing-extensions (authored by olasd).
Mark lower bound for typing-extensions
Mar 3 2022, 6:50 PM
olasd committed rSPSITE0597d7983fc9: Use the sync gunicorn workers for objstorage and vault (authored by olasd).
Use the sync gunicorn workers for objstorage and vault
Mar 3 2022, 6:36 PM
olasd accepted D7282: db_utils: Fix typing of db/conninfo objects.
Mar 3 2022, 6:18 PM
olasd accepted D7281: db_utils: Add missing import of psycopg2.errors.

Weird that we've never noticed this before.

Mar 3 2022, 6:17 PM
olasd accepted D7288: Remove dependency on pytest-asyncio.

This is great, thank you!

Mar 3 2022, 6:09 PM
olasd accepted D7287: Fix accidental dependency on 'psycopg2' and 'sh' via the winery backend.

Thanks

Mar 3 2022, 5:44 PM
olasd closed D7280: Properly split optional per-backend requirements.
Mar 3 2022, 1:53 PM
olasd committed rDOBJS686b70d868e4: Properly split optional per-backend requirements (authored by olasd).
Properly split optional per-backend requirements
Mar 3 2022, 1:53 PM
olasd updated the diff for D7280: Properly split optional per-backend requirements.

add more extras_require possibilities

Mar 3 2022, 1:50 PM