Page MenuHomeSoftware Heritage

Properly split optional per-backend requirements
ClosedPublic

Authored by olasd on Mar 3 2022, 1:26 PM.

Details

Summary

For now this is only used to reduce the dependencies generated by the
debian packaging, but we could use that to better isolate per-backend
tests too.

Test Plan

shouldn't affect testing

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7280 (id=26365)

Rebasing onto 16bb0433c7...

Current branch diff-target is up to date.
Changes applied before test
commit 0a2e0c38b01d25409b9bd7a9bca2a99018f3290d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Mar 3 13:25:37 2022 +0100

    Properly split optional per-backend requirements
    
    For now this is only used to reduce the dependencies generated by the
    debian packaging, but we could use that to better isolate per-backend
    tests too.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/138/ for more details.

olasd requested review of this revision.Mar 3 2022, 1:28 PM
setup.py
51–60

Shouldn't it declare extras like this, to make it easier to install with a specific backend?

setup.py
51–60

Yeah, you're right (even though that's really not a regression compared to the current state, well, except for winery).

add more extras_require possibilities

olasd marked an inline comment as done.Mar 3 2022, 1:50 PM

Build is green

Patch application report for D7280 (id=26369)

Rebasing onto 16bb0433c7...

Current branch diff-target is up to date.
Changes applied before test
commit 686b70d868e4e032b4c0d79887a390d9349d5253
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Mar 3 13:25:37 2022 +0100

    Properly split optional per-backend requirements
    
    For now this is only used to reduce the dependencies generated by the
    debian packaging, but we could use that to better isolate per-backend
    tests too.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/139/ for more details.

This revision is now accepted and ready to land.Mar 3 2022, 1:53 PM