Page MenuHomeSoftware Heritage

deposit: Check the status code of the REMD API.
ClosedPublic

Authored by vlorentz on Mar 4 2022, 6:53 PM.

Diff Detail

Repository
rDICP Icinga plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7305 (id=26428)

Could not rebase; Attempt merge onto 2676ebba5a...

Updating 2676ebb..e68a152
Fast-forward
 swh/icinga_plugins/deposit.py            | 22 +++++++--
 swh/icinga_plugins/tests/test_deposit.py | 85 ++++++++++++++++++++++++++------
 2 files changed, 87 insertions(+), 20 deletions(-)
Changes applied before test
commit e68a1529d3a70937a067f59280be1ea5da851a9d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 18:53:27 2022 +0100

    deposit: Check the status code of the REMD API.

commit 77273580c8b10910daa590b7a893c65223ed3ec5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 18:52:52 2022 +0100

    deposit: Properly escape URLs
    
    The '+' character in the 'after' was not escaped, so the server interpreted
    it as a space.

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/67/ for more details.

This revision is now accepted and ready to land.Mar 4 2022, 6:59 PM