use `objstorage is None` instead of `not objstorage`
ClosedPublic
Actions

Authored by olasd on Mar 3 2022, 7:53 PM.

Details

Reviewers

vlorentz

Maniphest Tasks

Restricted Maniphest Task

Commits

rDOBJS26201f451e8c: use `objstorage is None` instead of `not objstorage`

Summary

bool(objstorage) uses len(objstorage) != 0, which takes "a little bit"
of time on non-trivial objstorages...

Test Plan

the staging objstorages are not on fire anymore

Diff Detail

Repository

rDOBJS Object storage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 3 2022, 7:53 PM

Build is green

Patch application report for D7289 (id=26382)

Rebasing onto e90ea3e2cf...

Current branch diff-target is up to date.

Changes applied before test

commit 26201f451e8c39e3b765bb23896dce9b3301b3d1
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Mar 3 19:52:14 2022 +0100

    use `objstorage is None` instead of `not objstorage`
    
    `bool(objstorage)` uses `len(objstorage) != 0`, which takes "a little bit"
    of time on non-trivial objstorages...

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/143/ for more details.

Harbormaster completed remote builds in B27268: Diff 26382.Mar 3 2022, 7:56 PM

olasd requested review of this revision.Mar 3 2022, 7:56 PM

vlorentz accepted this revision.Mar 3 2022, 7:56 PM

This revision is now accepted and ready to land.Mar 3 2022, 7:56 PM

Closed by commit rDOBJS26201f451e8c: use `objstorage is None` instead of `not objstorage` (authored by olasd). · Explain WhyMar 3 2022, 7:57 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDOBJS26201f451e8c: use `objstorage is None` instead of `not objstorage`.

vlorentz added a task: Restricted Maniphest Task.Mar 7 2022, 9:25 AM