Page MenuHomeSoftware Heritage

deposit: Check metadata was archived verbatim
ClosedPublic

Authored by vlorentz on Mar 3 2022, 2:19 PM.

Details

Diff Detail

Repository
rDICP Icinga plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7284 (id=26372)

Could not rebase; Attempt merge onto 26a98cae80...

Updating 26a98ca..27a2ef9
Fast-forward
 swh/icinga_plugins/cli.py                |  12 ++
 swh/icinga_plugins/deposit.py            |  76 +++++++-
 swh/icinga_plugins/tests/test_deposit.py | 288 +++++++++++++++++++++++++++++--
 3 files changed, 357 insertions(+), 19 deletions(-)
Changes applied before test
commit 27a2ef97c1390f3de00cd89b175860cef862fdf3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Mar 3 14:19:01 2022 +0100

    deposit: Check metadata was archived verbatim

commit 726d2330afe1e4075e573f124ba37ace6911891d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Mar 3 10:54:45 2022 +0100

    deposit: Filter out metadata objects created before the check started
    
    Just to be safe, though it should not happen as origins are unique.

commit f45a54104015f97a0cdc164ea7d59089f9c0be35
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Mar 2 16:42:58 2022 +0100

    deposit: Check created metadata is visible from the public API

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/50/ for more details.

olasd added a subscriber: olasd.

Looks good, thank you!

This revision is now accepted and ready to land.Mar 4 2022, 10:51 AM